Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1959313002: Use ChannelMojo for the utility process. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-all-processes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ChannelMojo for the utility process. BUG=604282, 597124 Committed: https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375 Cr-Commit-Position: refs/heads/master@{#398221}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename function. #

Patch Set 3 : again #

Patch Set 4 : rebase #

Patch Set 5 : Rebase again. #

Patch Set 6 : Rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M content/browser/utility_process_host_impl.cc View 1 2 3 4 5 6 3 chunks +7 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/common/child_process_host_impl.h View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 5 6 4 chunks +26 lines, -2 lines 0 comments Download
M content/public/common/child_process_host.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (11 generated)
Anand Mistry (off Chromium)
Since ChannelMojo is the only option for renderers, might as well do it for the ...
4 years, 7 months ago (2016-05-10 06:31:42 UTC) #2
ncarter (slow)
lgtm https://codereview.chromium.org/1959313002/diff/1/content/common/child_process_host_impl.cc File content/common/child_process_host_impl.cc (right): https://codereview.chromium.org/1959313002/diff/1/content/common/child_process_host_impl.cc#newcode158 content/common/child_process_host_impl.cc:158: bool ChildProcessHostImpl::CreateChannelCommon() { Consider calling this InitChannel()/ConnectChannel()/AttachChannel() or ...
4 years, 7 months ago (2016-05-10 16:50:11 UTC) #3
Anand Mistry (off Chromium)
https://codereview.chromium.org/1959313002/diff/1/content/common/child_process_host_impl.cc File content/common/child_process_host_impl.cc (right): https://codereview.chromium.org/1959313002/diff/1/content/common/child_process_host_impl.cc#newcode158 content/common/child_process_host_impl.cc:158: bool ChildProcessHostImpl::CreateChannelCommon() { On 2016/05/10 16:50:10, ncarter wrote: > ...
4 years, 7 months ago (2016-05-11 00:21:22 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-11 16:11:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959313002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959313002/80001
4 years, 6 months ago (2016-06-01 03:03:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/221128)
4 years, 6 months ago (2016-06-01 04:25:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959313002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959313002/80001
4 years, 6 months ago (2016-06-01 04:26:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/221169)
4 years, 6 months ago (2016-06-01 05:37:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959313002/120001
4 years, 6 months ago (2016-06-07 00:29:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/225499)
4 years, 6 months ago (2016-06-07 01:28:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959313002/120001
4 years, 6 months ago (2016-06-07 01:39:02 UTC) #21
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-07 04:23:10 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 04:24:50 UTC) #24
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375
Cr-Commit-Position: refs/heads/master@{#398221}

Powered by Google App Engine
This is Rietveld 408576698