Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: build/android/buildbot/bb_run_bot.py

Issue 20210002: [Android] Sets up a coverage system for java using EMMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleans up temporary changes, fixes a few more small things Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/buildbot/bb_run_bot.py
diff --git a/build/android/buildbot/bb_run_bot.py b/build/android/buildbot/bb_run_bot.py
index 7637024693e8256515de422cd1f32c0c042d9e07..9f88a02f328da6fb7cd06b241b5b9a1e8096b9ae 100755
--- a/build/android/buildbot/bb_run_bot.py
+++ b/build/android/buildbot/bb_run_bot.py
@@ -19,6 +19,8 @@ sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
from pylib import constants
+CHROMIUM_COVERAGE_BUCKET = 'chromium-code-coverage'
+
_BotConfig = collections.namedtuple(
'BotConfig', ['bot_id', 'host_obj', 'test_obj'])
@@ -43,10 +45,11 @@ def DictDiff(d1, d2):
return '\n'.join(diff)
-def GetEnvironment(host_obj, testing):
+def GetEnvironment(host_obj, testing, bot_id):
init_env = dict(os.environ)
init_env['GYP_GENERATORS'] = 'ninja'
init_env['GOMA_DIR'] = bb_utils.GOMA_DIR
+ init_env['BUILDBOT_ID'] = bot_id
envsetup_cmd = '. build/android/envsetup.sh'
if host_obj.target_arch:
envsetup_cmd += ' --target-arch=%s' % host_obj.target_arch
@@ -144,12 +147,14 @@ def GetBotStepMap():
B('fyi-x86-builder-dbg',
H(compile_step + std_host_tests, experimental, target_arch='x86')),
B('fyi-builder-dbg',
- H(std_build_steps + std_host_tests, experimental)),
+ H(std_build_steps + std_host_tests, experimental,
+ extra_gyp='emma_coverage=1')),
B('x86-builder-dbg',
H(compile_step + std_host_tests, target_arch='x86')),
B('fyi-builder-rel', H(std_build_steps, experimental)),
B('fyi-tests', H(std_test_steps),
- T(std_tests, ['--experimental', flakiness_server])),
+ T(std_tests, ['--experimental', flakiness_server,
+ '--coverage-bucket', CHROMIUM_COVERAGE_BUCKET])),
B('fyi-component-builder-tests-dbg',
H(compile_step, extra_gyp='component=shared_library'),
T(std_tests, ['--experimental', flakiness_server])),
@@ -265,7 +270,8 @@ def main(argv):
print 'Will run: ', bb_utils.CommandToString(command)
print
- env = GetEnvironment(bot_config.host_obj, options.testing)
+ bot_id = options.bot_id or options.factory_properties.get('android_bot_id')
+ env = GetEnvironment(bot_config.host_obj, options.testing, bot_id)
return RunBotCommands(options, commands, env)

Powered by Google App Engine
This is Rietveld 408576698