third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a unit test. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodController.h

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h

index bf7e152cad58c360be8cf1e35fa5a88e6c2217de..20ec070f5a6b7eb2ef6cd8a3451fff776bd133a6 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.h

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h

@@ -76,7 +76,7 @@ public:

PlainTextRange getSelectionOffsets() const;

// Returns true if setting selection to specified offsets, otherwise false.

- bool setEditableSelectionOffsets(const PlainTextRange&);

+ bool setEditableSelectionOffsets(int start, int end);

yosin_UTC9 2016/06/03 07:16:11 Could you explain benefit of you replace |PlaintTe

void extendSelectionAndDelete(int before, int after);

private: