Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a unit test. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 void cancelComposition(); 69 void cancelComposition();
70 void cancelCompositionIfSelectionIsInvalid(); 70 void cancelCompositionIfSelectionIsInvalid();
71 EphemeralRange compositionEphemeralRange() const; 71 EphemeralRange compositionEphemeralRange() const;
72 Range* compositionRange() const; 72 Range* compositionRange() const;
73 73
74 void clear(); 74 void clear();
75 void documentDetached(); 75 void documentDetached();
76 76
77 PlainTextRange getSelectionOffsets() const; 77 PlainTextRange getSelectionOffsets() const;
78 // Returns true if setting selection to specified offsets, otherwise false. 78 // Returns true if setting selection to specified offsets, otherwise false.
79 bool setEditableSelectionOffsets(const PlainTextRange&); 79 bool setEditableSelectionOffsets(int start, int end);
yosin_UTC9 2016/06/03 07:16:11 Could you explain benefit of you replace |PlaintTe
80 void extendSelectionAndDelete(int before, int after); 80 void extendSelectionAndDelete(int before, int after);
81 81
82 private: 82 private:
83 class SelectionOffsetsScope { 83 class SelectionOffsetsScope {
84 WTF_MAKE_NONCOPYABLE(SelectionOffsetsScope); 84 WTF_MAKE_NONCOPYABLE(SelectionOffsetsScope);
85 STACK_ALLOCATED(); 85 STACK_ALLOCATED();
86 public: 86 public:
87 explicit SelectionOffsetsScope(InputMethodController*); 87 explicit SelectionOffsetsScope(InputMethodController*);
88 ~SelectionOffsetsScope(); 88 ~SelectionOffsetsScope();
89 private: 89 private:
(...skipping 17 matching lines...) Expand all
107 } 107 }
108 108
109 String composingText() const; 109 String composingText() const;
110 void selectComposition() const; 110 void selectComposition() const;
111 bool setSelectionOffsets(const PlainTextRange&); 111 bool setSelectionOffsets(const PlainTextRange&);
112 }; 112 };
113 113
114 } // namespace blink 114 } // namespace blink
115 115
116 #endif // InputMethodController_h 116 #endif // InputMethodController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698