third_party/WebKit/Source/web/WebViewImpl.h - Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check the boundary in WebViewImpl instead of render_widget Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('K') | « third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index af2b14985a8f9cb3a489a53b8682e734f72b6692..7fd4ac8c3a3c6cd62aee9df3d66c665b0515be99 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -623,6 +623,9 @@ private:

void attachCompositorAnimationTimeline(CompositorAnimationTimeline*);

void detachCompositorAnimationTimeline(CompositorAnimationTimeline*);

+ // When selection exceeds the boundary, it should stay at the boundary.

+ std::pair<int, int> adjustSelectionForBoundary(int selectionStart, int selectionEnd, const int textLength);

WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)

WebSpellCheckClient* m_spellCheckClient;