Chromium Code Reviews

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2020973002: Reland: Fix setComposingText with empty text when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check the boundary in WebViewImpl instead of render_widget Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 605 matching lines...)
616 616
617 void cancelPagePopup(); 617 void cancelPagePopup();
618 void updatePageOverlays(); 618 void updatePageOverlays();
619 619
620 float deviceScaleFactor() const; 620 float deviceScaleFactor() const;
621 621
622 void setRootGraphicsLayer(GraphicsLayer*); 622 void setRootGraphicsLayer(GraphicsLayer*);
623 void attachCompositorAnimationTimeline(CompositorAnimationTimeline*); 623 void attachCompositorAnimationTimeline(CompositorAnimationTimeline*);
624 void detachCompositorAnimationTimeline(CompositorAnimationTimeline*); 624 void detachCompositorAnimationTimeline(CompositorAnimationTimeline*);
625 625
626 // When selection exceeds the boundary, it should stay at the boundary.
627 std::pair<int, int> adjustSelectionForBoundary(int selectionStart, int selec tionEnd, const int textLength);
628
626 WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.) 629 WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
627 WebSpellCheckClient* m_spellCheckClient; 630 WebSpellCheckClient* m_spellCheckClient;
628 631
629 Persistent<ChromeClientImpl> m_chromeClientImpl; 632 Persistent<ChromeClientImpl> m_chromeClientImpl;
630 ContextMenuClientImpl m_contextMenuClientImpl; 633 ContextMenuClientImpl m_contextMenuClientImpl;
631 EditorClientImpl m_editorClientImpl; 634 EditorClientImpl m_editorClientImpl;
632 SpellCheckerClientImpl m_spellCheckerClientImpl; 635 SpellCheckerClientImpl m_spellCheckerClientImpl;
633 StorageClientImpl m_storageClientImpl; 636 StorageClientImpl m_storageClientImpl;
634 637
635 WebSize m_size; 638 WebSize m_size;
(...skipping 135 matching lines...)
771 bool m_overrideCompositorVisibility; 774 bool m_overrideCompositorVisibility;
772 }; 775 };
773 776
774 // We have no ways to check if the specified WebView is an instance of 777 // We have no ways to check if the specified WebView is an instance of
775 // WebViewImpl because WebViewImpl is the only implementation of WebView. 778 // WebViewImpl because WebViewImpl is the only implementation of WebView.
776 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 779 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
777 780
778 } // namespace blink 781 } // namespace blink
779 782
780 #endif 783 #endif
OLDNEW

Powered by Google App Engine