Chromium Code Reviews Chromium Code Reviews
Issue 2020893002:
Convert controls-css*, controls-drag* and controls-overlay* tests to testharness.js (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/media/controls-css-overload.html |
| diff --git a/third_party/WebKit/LayoutTests/media/controls-css-overload.html b/third_party/WebKit/LayoutTests/media/controls-css-overload.html |
| index cd66186d7ca250ecd9afe188041935b65205909f..94f24fe9c6c69f6f40bdb46b626e7686136ed185 100644 |
| --- a/third_party/WebKit/LayoutTests/media/controls-css-overload.html |
| +++ b/third_party/WebKit/LayoutTests/media/controls-css-overload.html |
| @@ -1,27 +1,24 @@ |
| -<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" |
| - "http://www.w3.org/TR/html4/strict.dtd"> |
| +<!DOCTYPE html> |
| +<title>Testing that overloading some controls doesn't crash the browser</title> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="media-file.js"></script> |
| +<style> |
| + .nocontrols::-webkit-media-controls-panel { |
| + display:none; |
| + } |
| + .notimeline::-webkit-media-controls-timeline-container { |
| + display:none; |
| + } |
| +</style> |
| +<video class="nocontrols notimeline" width=300 height=200 controls></video> |
|
fs
2016/05/29 14:28:17
Should probably keep the two <video> from the old
Srirama
2016/05/30 13:19:19
Done.
|
| +<script> |
| +async_test(function(t) { |
|
fs
2016/05/29 14:28:17
The old version wasn't async - IIRC, this test onl
Srirama
2016/05/30 13:19:19
I don't know what to keep in the test() function,
fs
2016/05/30 13:37:22
Thanks for digging that up. Empty test() seems fin
Srirama
2016/05/30 13:59:22
Fine, i will also go with empty one.
|
| + var video = document.querySelector("video"); |
| + video.src = findMediaFile("video", "content/test"); |
| -<html> |
| -<head> |
| - <title>Testing that overloading some controls doesn't crash the browser</title> |
| - <style> |
| - .nocontrols::-webkit-media-controls-panel{ |
| - display:none; |
| - } |
| - .notimeline::-webkit-media-controls-timeline-container{ |
| - display:none; |
| - } |
| - </style> |
| - <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956 |
| - (Please avoid writing new tests using video-test.js) --> |
| - <script src=video-test.js></script> |
| -</head> |
| -<body> |
| - <video class="nocontrols" width=300 height=200 controls></video> |
| - <video class="notimeline" width=300 height=200 controls></video> |
| - <script> |
| - consoleWrite("I did not crash"); |
| - endTest(); |
| - </script> |
| + video.oncanplaythrough = t.step_func_done(); |
| +}); |
| +</script> |
| </body> |
| </html> |
