Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2020833002: Add the request picker and a unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per Dimich and DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index ab506f0aab026eeacf09e13283d31e26ba100f8b..28bbf2155203472a5ea1d4e7b97f65519923e85d 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -172,12 +172,6 @@ TEST_F(RequestCoordinatorTest, SavePageLater) {
SchedulerStub* scheduler_stub = reinterpret_cast<SchedulerStub*>(
coordinator()->GetSchedulerForTesting());
EXPECT_TRUE(scheduler_stub->schedule_called());
-
- // Check that the offliner callback got a response.
- EXPECT_EQ(Offliner::RequestStatus::SAVED,
- coordinator()->last_offlining_status());
-
- // TODO(petewil): Expect that the scheduler got notified.
}
} // namespace offline_pages
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_picker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698