Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2020833002: Add the request picker and a unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per Dimich and DougArnett Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_coordinator.h" 5 #include "components/offline_pages/background/request_coordinator.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 165
166 // Check the request queue is as expected. 166 // Check the request queue is as expected.
167 EXPECT_EQ(1UL, last_requests().size()); 167 EXPECT_EQ(1UL, last_requests().size());
168 EXPECT_EQ(kUrl, last_requests()[0].url()); 168 EXPECT_EQ(kUrl, last_requests()[0].url());
169 EXPECT_EQ(kClientId, last_requests()[0].client_id()); 169 EXPECT_EQ(kClientId, last_requests()[0].client_id());
170 170
171 // Expect that the scheduler got notified. 171 // Expect that the scheduler got notified.
172 SchedulerStub* scheduler_stub = reinterpret_cast<SchedulerStub*>( 172 SchedulerStub* scheduler_stub = reinterpret_cast<SchedulerStub*>(
173 coordinator()->GetSchedulerForTesting()); 173 coordinator()->GetSchedulerForTesting());
174 EXPECT_TRUE(scheduler_stub->schedule_called()); 174 EXPECT_TRUE(scheduler_stub->schedule_called());
175
176 // Check that the offliner callback got a response.
177 EXPECT_EQ(Offliner::RequestStatus::SAVED,
178 coordinator()->last_offlining_status());
179
180 // TODO(petewil): Expect that the scheduler got notified.
181 } 175 }
182 176
183 } // namespace offline_pages 177 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/request_picker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698