Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/gcm_internals.html

Issue 202083005: Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address all code reviews. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/gcm_internals.css ('k') | chrome/browser/resources/gcm_internals.js » ('j') | chrome/browser/resources/gcm_internals.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/gcm_internals.html
diff --git a/chrome/browser/resources/gcm_internals.html b/chrome/browser/resources/gcm_internals.html
index 775a9228b19d4d01cad1397f70bb1b6a8f369e63..db7998f319eb66be5331dbcdc4ec92e11f4b71ee 100644
--- a/chrome/browser/resources/gcm_internals.html
+++ b/chrome/browser/resources/gcm_internals.html
@@ -13,74 +13,124 @@
</head>
<body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
<h1>GCM Internals</h1>
-<div>
- <h2>Device Info</h2>
- <table>
- <tr class="odd-number-row">
- <td class="row-caption">
- Android Id
- </td>
- <td id="android-id">
- </td>
- </tr>
- <tr>
- <td class="row-caption">
- User Profile Service Created
- </td>
- <td id="profile-service-created">
- </td>
- </tr>
- <tr class="odd-number-row">
- <td class="row-caption">
- GCM Enabled State
- </td>
- <td id="gcm-enabled-state">
- </td>
- </tr>
+<table cellpadding="5" cellspacing="0">
arv (Not doing code reviews) 2014/03/24 18:47:05 Move to css
arv (Not doing code reviews) 2014/03/24 18:47:05 Why the table? Maybe display: flex would allow you
juyik 2014/03/26 04:06:03 Done.
juyik 2014/03/26 04:06:03 Done.
+ <tr valign="center">
arv (Not doing code reviews) 2014/03/24 18:47:05 move to css
juyik 2014/03/26 04:06:03 Done.
+ <td>
+ <button id="refresh">Refresh</button>
+ </td>
+ <td>
+ <button id="recording">Start Recording</button>
+ </td>
+ <td>
+ <button id="clear-logs">Clear All Logs</button>
+ </td>
+ </tr>
+</table>
+
+<h2>Device Info</h2>
+<table>
+ <tr class="odd-number-row">
+ <td class="row-caption">
+ Android Id
+ </td>
+ <td id="android-id">
+ </td>
+ </tr>
+ <tr>
+ <td class="row-caption">
+ User Profile Service Created
+ </td>
+ <td id="profile-service-created">
+ </td>
+ </tr>
+ <tr class="odd-number-row">
arv (Not doing code reviews) 2014/03/24 18:47:05 Can you use CSS instead? :nth-child(odd)
juyik 2014/03/26 04:06:03 Done.
+ <td class="row-caption">
+ GCM Enabled State
+ </td>
+ <td id="gcm-enabled-state">
+ </td>
+ </tr>
+ <tr>
+ <td class="row-caption">
+ Signed In Username
+ </td>
+ <td id="signed-in-username">
+ </td>
+ </tr>
+ <tr class="odd-number-row">
+ <td class="row-caption">
+ GCM Client Created
+ </td>
+ <td id="gcm-client-created">
+ </td>
+ </tr>
+ <tr>
+ <td class="row-caption">
+ GCM Client State
+ </td>
+ <td id="gcm-client-state">
+ </td>
+ </tr>
+ <tr class="odd-number-row">
+ <td class="row-caption">
+ GCM Client Is Ready
+ </td>
+ <td id="gcm-client-ready">
+ </td>
+ </tr>
+ <tr>
+ <td class="row-caption">
+ Connection Client Created
+ </td>
+ <td id="connection-client-created">
+ </td>
+ </tr>
+ <tr class="odd-number-row">
+ <td class="row-caption">
+ Connection State
+ </td>
+ <td id="connection-state">
+ </td>
+ </tr>
+ <tr>
+ <td class="row-caption">
+ App Ids Having Cached Registration Info
+ </td>
+ <td id="app-ids-cached">
+ </td>
+ </tr>
+ <tr class="odd-number-row">
+ <td class="row-caption">
+ Send Message Queue Size
+ </td>
+ <td id="send-queue-size">
+ </td>
+ </tr>
+ <tr>
+ <td class="row-caption">
+ Unacked Message Queue Size
+ </td>
+ <td id="unacked-queue-size">
+ </td>
+ </tr>
+</table>
+
+<h2>Send Message Log</h2>
+<table class="log-table">
+ <thead>
<tr>
- <td class="row-caption">
- Signed In Username
- </td>
- <td id="signed-in-username">
- </td>
- </tr>
- <tr class="odd-number-row">
- <td class="row-caption">
- GCM Client Created
- </td>
- <td id="gcm-client-created">
- </td>
- </tr>
- <tr>
- <td class="row-caption">
- GCM Client State
- </td>
- <td id="gcm-client-state">
- </td>
- </tr>
- <tr class="odd-number-row">
- <td class="row-caption">
- GCM Client Is Ready
- </td>
- <td id="gcm-client-ready">
- </td>
- </tr>
- <tr>
- <td class="row-caption">
- Connection Client Created
- </td>
- <td id="connection-client-created">
- </td>
- </tr>
- <tr class="odd-number-row">
- <td class="row-caption">
- Connection State
- </td>
- <td id="connection-state">
- </td>
+ <th class="info-heading">Time</th>
arv (Not doing code reviews) 2014/03/24 18:47:05 Why do all of these need to repeat the class? Can
juyik 2014/03/26 04:06:03 Done.
+ <th class="info-heading">App Id</th>
+ <th class="info-heading">Receiver Id</th>
+ <th class="info-heading">Msg Id</th>
+ <th class="info-heading">Event</th>
+ <th class="info-heading">Details</th>
</tr>
- </table>
-</div>
+ </thead>
+ <tbody id="send-info">
+ </tbody>
+</table>
+
<script src="chrome://resources/js/i18n_template2.js"></script>
</body>
</html>
« no previous file with comments | « chrome/browser/resources/gcm_internals.css ('k') | chrome/browser/resources/gcm_internals.js » ('j') | chrome/browser/resources/gcm_internals.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698