Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/gcm_internals.html

Issue 202083005: Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address all code reviews. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/gcm_internals.css ('k') | chrome/browser/resources/gcm_internals.js » ('j') | chrome/browser/resources/gcm_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection"> 2 <html i18n-values="dir:textdirection">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <title>GCM Internals</title> 5 <title>GCM Internals</title>
6 <link rel="stylesheet" href="gcm_internals.css"> 6 <link rel="stylesheet" href="gcm_internals.css">
7 <script src="chrome://resources/js/cr.js"></script> 7 <script src="chrome://resources/js/cr.js"></script>
8 <script src="chrome://resources/js/load_time_data.js"></script> 8 <script src="chrome://resources/js/load_time_data.js"></script>
9 <script src="chrome://resources/js/cr/ui.js"></script> 9 <script src="chrome://resources/js/cr/ui.js"></script>
10 <script src="chrome://resources/js/util.js"></script> 10 <script src="chrome://resources/js/util.js"></script>
11 <script src="strings.js"></script> 11 <script src="strings.js"></script>
12 <script src="gcm_internals.js"></script> 12 <script src="gcm_internals.js"></script>
13 </head> 13 </head>
14 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 14 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
15 <h1>GCM Internals</h1> 15 <h1>GCM Internals</h1>
16 <div> 16 <table cellpadding="5" cellspacing="0">
arv (Not doing code reviews) 2014/03/24 18:47:05 Move to css
arv (Not doing code reviews) 2014/03/24 18:47:05 Why the table? Maybe display: flex would allow you
juyik 2014/03/26 04:06:03 Done.
juyik 2014/03/26 04:06:03 Done.
17 <h2>Device Info</h2> 17 <tr valign="center">
arv (Not doing code reviews) 2014/03/24 18:47:05 move to css
juyik 2014/03/26 04:06:03 Done.
18 <table> 18 <td>
19 <tr class="odd-number-row"> 19 <button id="refresh">Refresh</button>
20 <td class="row-caption"> 20 </td>
21 Android Id 21 <td>
22 </td> 22 <button id="recording">Start Recording</button>
23 <td id="android-id"> 23 </td>
24 </td> 24 <td>
25 <button id="clear-logs">Clear All Logs</button>
26 </td>
27 </tr>
28 </table>
29
30 <h2>Device Info</h2>
31 <table>
32 <tr class="odd-number-row">
33 <td class="row-caption">
34 Android Id
35 </td>
36 <td id="android-id">
37 </td>
38 </tr>
39 <tr>
40 <td class="row-caption">
41 User Profile Service Created
42 </td>
43 <td id="profile-service-created">
44 </td>
45 </tr>
46 <tr class="odd-number-row">
arv (Not doing code reviews) 2014/03/24 18:47:05 Can you use CSS instead? :nth-child(odd)
juyik 2014/03/26 04:06:03 Done.
47 <td class="row-caption">
48 GCM Enabled State
49 </td>
50 <td id="gcm-enabled-state">
51 </td>
52 </tr>
53 <tr>
54 <td class="row-caption">
55 Signed In Username
56 </td>
57 <td id="signed-in-username">
58 </td>
59 </tr>
60 <tr class="odd-number-row">
61 <td class="row-caption">
62 GCM Client Created
63 </td>
64 <td id="gcm-client-created">
65 </td>
66 </tr>
67 <tr>
68 <td class="row-caption">
69 GCM Client State
70 </td>
71 <td id="gcm-client-state">
72 </td>
73 </tr>
74 <tr class="odd-number-row">
75 <td class="row-caption">
76 GCM Client Is Ready
77 </td>
78 <td id="gcm-client-ready">
79 </td>
80 </tr>
81 <tr>
82 <td class="row-caption">
83 Connection Client Created
84 </td>
85 <td id="connection-client-created">
86 </td>
87 </tr>
88 <tr class="odd-number-row">
89 <td class="row-caption">
90 Connection State
91 </td>
92 <td id="connection-state">
93 </td>
94 </tr>
95 <tr>
96 <td class="row-caption">
97 App Ids Having Cached Registration Info
98 </td>
99 <td id="app-ids-cached">
100 </td>
101 </tr>
102 <tr class="odd-number-row">
103 <td class="row-caption">
104 Send Message Queue Size
105 </td>
106 <td id="send-queue-size">
107 </td>
108 </tr>
109 <tr>
110 <td class="row-caption">
111 Unacked Message Queue Size
112 </td>
113 <td id="unacked-queue-size">
114 </td>
115 </tr>
116 </table>
117
118 <h2>Send Message Log</h2>
119 <table class="log-table">
120 <thead>
121 <tr>
122 <th class="info-heading">Time</th>
arv (Not doing code reviews) 2014/03/24 18:47:05 Why do all of these need to repeat the class? Can
juyik 2014/03/26 04:06:03 Done.
123 <th class="info-heading">App Id</th>
124 <th class="info-heading">Receiver Id</th>
125 <th class="info-heading">Msg Id</th>
126 <th class="info-heading">Event</th>
127 <th class="info-heading">Details</th>
25 </tr> 128 </tr>
26 <tr> 129 </thead>
27 <td class="row-caption"> 130 <tbody id="send-info">
28 User Profile Service Created 131 </tbody>
29 </td> 132 </table>
30 <td id="profile-service-created"> 133
31 </td>
32 </tr>
33 <tr class="odd-number-row">
34 <td class="row-caption">
35 GCM Enabled State
36 </td>
37 <td id="gcm-enabled-state">
38 </td>
39 </tr>
40 <tr>
41 <td class="row-caption">
42 Signed In Username
43 </td>
44 <td id="signed-in-username">
45 </td>
46 </tr>
47 <tr class="odd-number-row">
48 <td class="row-caption">
49 GCM Client Created
50 </td>
51 <td id="gcm-client-created">
52 </td>
53 </tr>
54 <tr>
55 <td class="row-caption">
56 GCM Client State
57 </td>
58 <td id="gcm-client-state">
59 </td>
60 </tr>
61 <tr class="odd-number-row">
62 <td class="row-caption">
63 GCM Client Is Ready
64 </td>
65 <td id="gcm-client-ready">
66 </td>
67 </tr>
68 <tr>
69 <td class="row-caption">
70 Connection Client Created
71 </td>
72 <td id="connection-client-created">
73 </td>
74 </tr>
75 <tr class="odd-number-row">
76 <td class="row-caption">
77 Connection State
78 </td>
79 <td id="connection-state">
80 </td>
81 </tr>
82 </table>
83 </div>
84 <script src="chrome://resources/js/i18n_template2.js"></script> 134 <script src="chrome://resources/js/i18n_template2.js"></script>
85 </body> 135 </body>
86 </html> 136 </html>
OLDNEW
« no previous file with comments | « chrome/browser/resources/gcm_internals.css ('k') | chrome/browser/resources/gcm_internals.js » ('j') | chrome/browser/resources/gcm_internals.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698