Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an…

google_apis/gcm/gcm_client.h

Index: google_apis/gcm/gcm_client.h
diff --git a/google_apis/gcm/gcm_client.h b/google_apis/gcm/gcm_client.h
index 0d687120947473d26b8218209dbb45b7b065e63b..c55ee0179f0648ddfd3dec0cc2a14ec9509391ba 100644
--- a/google_apis/gcm/gcm_client.h
+++ b/google_apis/gcm/gcm_client.h
@@ -11,6 +11,7 @@
 
 #include "base/basictypes.h"
 #include "google_apis/gcm/base/gcm_export.h"
+#include "google_apis/gcm/gcm_stats_recorder.h"
 
 template <class T> class scoped_refptr;
 
@@ -94,11 +95,20 @@ class GCM_EXPORT GCMClient {
     GCMStatistics();
     ~GCMStatistics();
 
+    bool is_recording;
     bool gcm_client_created;
     std::string gcm_client_state;
     bool connection_client_created;
     std::string connection_state;
     uint64 android_id;
+    std::string app_ids_cached;
+    int send_queue_size;
+    int unacked_queue_size;
+
+    std::vector<GCMStatsRecorder::CheckinActivity> checkins;
+    std::vector<GCMStatsRecorder::RegisterActivity> registers;
+    std::vector<GCMStatsRecorder::SendMessageActivity> sent_messages;
+    std::vector<GCMStatsRecorder::ReceiveMessageActivity> received_messages;
   };
 
   // A delegate interface that allows the GCMClient instance to interact with
@@ -208,6 +218,12 @@ class GCM_EXPORT GCMClient {
                     const std::string& receiver_id,
                     const OutgoingMessage& message) = 0;
 
+  // Enables or disables internal activity recording.
+  virtual void SetRecording(bool recording) = 0;

[fgorski, 2014/03/18 21:28:37]

Did you consider have SetRecording directly on the recorder?

[juyik, 2014/03/20 01:09:53]

It is already on the recorder. I felt that recorder is embedded insode the
client instance and we should not expose recorder instance externally. Therefore
this method will call recorder_.SetRecording() on behalf of the caller..

+
+  // Clear all recorded GCM activity logs.
+  virtual void ClearActivityLogs() = 0;
+
   // Gets internal states and statistics.
   virtual GCMStatistics GetStatistics() const = 0;
 };