Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an…

google_apis/gcm/gcm_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GOOGLE_APIS_GCM_GCM_CLIENT_H_
 #define GOOGLE_APIS_GCM_GCM_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "google_apis/gcm/base/gcm_export.h"
+#include "google_apis/gcm/gcm_stats_recorder.h"
 
 template <class T> class scoped_refptr;
 
 namespace base {
 class FilePath;
 class SequencedTaskRunner;
 }
 
 namespace checkin_proto {
 class ChromeBuildProto;
@@ skipping 63 matching lines @@
     MessageData additional_data;
     Result result;
   };
 
   // Internal states and activity statistics of a GCM client.
   struct GCM_EXPORT GCMStatistics {
    public:
     GCMStatistics();
     ~GCMStatistics();
 
+    bool is_recording;
     bool gcm_client_created;
     std::string gcm_client_state;
     bool connection_client_created;
     std::string connection_state;
     uint64 android_id;
+    std::string app_ids_cached;
+    int send_queue_size;
+    int unacked_queue_size;
+
+    std::vector<GCMStatsRecorder::CheckinActivity> checkins;
+    std::vector<GCMStatsRecorder::RegisterActivity> registers;
+    std::vector<GCMStatsRecorder::SendMessageActivity> sent_messages;
+    std::vector<GCMStatsRecorder::ReceiveMessageActivity> received_messages;
   };
 
   // A delegate interface that allows the GCMClient instance to interact with
   // its caller, i.e. notifying asynchronous event.
   class Delegate {
    public:
     // Called when the registration completed successfully or an error occurs.
     // |app_id|: application ID.
     // |registration_id|: non-empty if the registration completed successfully.
     // |result|: the type of the error if an error occured, success otherwise.
@@ skipping 89 matching lines @@
 
   // Sends a message to a given receiver. Delegate::OnSendFinished will be
   // called asynchronously upon completion.
   // |app_id|: application ID.
   // |receiver_id|: registration ID of the receiver party.
   // |message|: message to be sent.
   virtual void Send(const std::string& app_id,
                     const std::string& receiver_id,
                     const OutgoingMessage& message) = 0;
 
+  // Enables or disables internal activity recording.
+  virtual void SetRecording(bool recording) = 0;

[fgorski, 2014/03/18 21:28:37]

Did you consider have SetRecording directly on the recorder?

[juyik, 2014/03/20 01:09:53]

It is already on the recorder. I felt that recorder is embedded insode the
client instance and we should not expose recorder instance externally. Therefore
this method will call recorder_.SetRecording() on behalf of the caller..

+
+  // Clear all recorded GCM activity logs.
+  virtual void ClearActivityLogs() = 0;
+
   // Gets internal states and statistics.
   virtual GCMStatistics GetStatistics() const = 0;
 };
 
 }  // namespace gcm
 
 #endif  // GOOGLE_APIS_GCM_GCM_CLIENT_H_