Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: webkit/glue/password_form_dom_manager.cc

Issue 20208: Lots of small nits to help to split off webkit.dll.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/password_form_dom_manager.h ('k') | webkit/glue/plugins/webplugin_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/password_form_dom_manager.cc
===================================================================
--- webkit/glue/password_form_dom_manager.cc (revision 9653)
+++ webkit/glue/password_form_dom_manager.cc (working copy)
@@ -62,15 +62,13 @@
}
// static
-PasswordFormDomManager::FillData* PasswordFormDomManager::CreateFillData(
+void PasswordFormDomManager::InitFillData(
const PasswordForm& form_on_page,
const PasswordFormMap& matches,
const PasswordForm* const preferred_match,
- bool wait_for_username_before_autofill) {
+ bool wait_for_username_before_autofill,
+ PasswordFormDomManager::FillData* result) {
DCHECK(preferred_match);
- PasswordFormDomManager::FillData* result =
- new PasswordFormDomManager::FillData();
-
// Fill basic form data.
result->basic_data.origin = form_on_page.origin;
result->basic_data.action = form_on_page.action;
@@ -87,7 +85,6 @@
if (iter->second != preferred_match)
result->additional_logins[iter->first] = iter->second->password_value;
}
- return result;
}
// static
« no previous file with comments | « webkit/glue/password_form_dom_manager.h ('k') | webkit/glue/plugins/webplugin_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698