Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2020733002: Fix printing issue of list item with blank first line (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix printing issue of list item with blank first line The problem was that LayoutObject::addElementVisualOverflowRects() doesn't cover list markers. Filed crbug.com/614781 for this. Let BlockPainter unite its visual overflow and the result of addElementVisualOverflowRects() to ensure whole visual overflow coverage. BUG=614262 TEST=printing/list-item-with-empty-first-line.html Review-Url: https://codereview.chromium.org/2011863005 Cr-Commit-Position: refs/heads/master@{#396046} Committed: https://chromium.googlesource.com/chromium/src/+/343998e6bc865e694516e2c340d47d1d171345f7

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Xianzhu
4 years, 6 months ago (2016-05-27 19:04:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
343998e6bc865e694516e2c340d47d1d171345f7.

Powered by Google App Engine
This is Rietveld 408576698