Fix printing issue of list item with blank first line

Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed crbug.com/614781 for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG=614262
TEST=printing/list-item-with-empty-first-line.html

Committed: https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89
Cr-Commit-Position: refs/heads/master@{#396046}

[Xianzhu, 2016-05-25 19:25:03]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-05-25 19:41:50]

Description was changed from

==========
Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed crbug.com/614781 for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG=614262
==========

to

==========
Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed crbug.com/614781 for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG=614262
TEST=printing/list-item-with-empty-first-line.html
==========

[chrishtr, 2016-05-25 20:09:40]

https://codereview.chromium.org/2011863005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BlockPainter.cpp (right):

https://codereview.chromium.org/2011863005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:226:
overflowRect.unite(m_layoutBlock.visualOverflowRect());
Is this too big of a hammer for this issue?

[chrishtr, 2016-05-25 20:10:46]

lgtm

https://codereview.chromium.org/2011863005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BlockPainter.cpp (right):

https://codereview.chromium.org/2011863005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:226:
overflowRect.unite(m_layoutBlock.visualOverflowRect());
On 2016/05/25 at 20:09:40, chrishtr wrote:
> Is this too big of a hammer for this issue?

I guess it's just a performance optimization, so ok.

[Xianzhu, 2016-05-25 20:16:19]

https://codereview.chromium.org/2011863005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BlockPainter.cpp (right):

https://codereview.chromium.org/2011863005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BlockPainter.cpp:226:
overflowRect.unite(m_layoutBlock.visualOverflowRect());
On 2016/05/25 20:10:46, chrishtr wrote:
> On 2016/05/25 at 20:09:40, chrishtr wrote:
> > Is this too big of a hammer for this issue?
> 
> I guess it's just a performance optimization, so ok.

We can think of this as: when printing anonymous block containing a link with
continuations, besides the visual overflow of the block itself, we also need to
include the visual overflow of the continuations (by
addElementVisualOverflowRects).

[Xianzhu, 2016-05-25 20:16:24]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:17:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011863005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011863005/20001

[commit-bot: I haz the power, 2016-05-25 20:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:27:26]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Xianzhu, 2016-05-25 20:37:53]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011863005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011863005/20001

[commit-bot: I haz the power, 2016-05-25 21:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:31:02]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-05-25 21:54:31]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-05-25 21:54:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2011863005/#ps40001
(title: "virtual/threaded/printing/list-item-with-empty-first-line.html")

[commit-bot: I haz the power, 2016-05-25 21:55:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011863005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011863005/40001

[commit-bot: I haz the power, 2016-05-25 23:54:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-25 23:55:12]

Description was changed from

==========
Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed crbug.com/614781 for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG=614262
TEST=printing/list-item-with-empty-first-line.html
==========

to

==========
Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed crbug.com/614781 for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG=614262
TEST=printing/list-item-with-empty-first-line.html

Committed: https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89
Cr-Commit-Position: refs/heads/master@{#396046}
==========

[commit-bot: I haz the power, 2016-05-25 23:55:13]

Patchset 3 (id:??) landed as
https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89
Cr-Commit-Position: refs/heads/master@{#396046}