Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2020563006: [Merge to M51] Fix the issue that Apps window keeps moving down to the right when reopened. (Closed)

Created:
4 years, 6 months ago by xdai1
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Merge to M51] Fix the issue that Apps window keeps moving down to the right when reopened. It's merged into M51 on behalf of warx@. Hide animation may have changed the transform, when recreating layer if we don't reset the transform, the installed transform from last hiding animation (such as a closing window operation) will cause window bounds changed. BUG=602661 TBR=sky@chromium.org TEST=add unittest in visibility_controller Review-Url: https://codereview.chromium.org/1986963003 Cr-Commit-Position: refs/heads/master@{#394340} (cherry picked from commit ac95109db90a079c1d56bc61b5a2b27b2b2fae63) Committed: https://chromium.googlesource.com/chromium/src/+/0d99651952addde3c579d2ffeb3f02fc1912c48f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M ui/wm/core/visibility_controller_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xdai1
4 years, 6 months ago (2016-05-27 23:01:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d99651952addde3c579d2ffeb3f02fc1912c48f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698