Apps window keeps moving down to the right when reopened

Hide animation may have changed the transform, when recreating layer if we don't reset the transform, the installed transform from last hiding animation (such as a closing window operation) will cause window bounds changed.

BUG=602661
TEST=add unittest in visibility_controller

Committed: https://crrev.com/ac95109db90a079c1d56bc61b5a2b27b2b2fae63
Cr-Commit-Position: refs/heads/master@{#394340}

[Qiang(Joe) Xu, 2016-05-17 21:44:16]

Description was changed from

==========
Apps window keeps moving down to the right when reopened

BUG=602661
TEST=add unittest in visibility_controller
==========

to

==========
Apps window keeps moving down to the right when reopened

BUG=602661
TEST=add unittest in visibility_controller
==========

[Qiang(Joe) Xu, 2016-05-17 21:44:17]

warx@chromium.org changed reviewers:
+ sky@chromium.org

[Qiang(Joe) Xu, 2016-05-17 21:44:55]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 21:45:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986963003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986963003/1

[commit-bot: I haz the power, 2016-05-17 23:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 23:43:13]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2016-05-17 23:44:15]

sky, could you help review on this? tks.

[sky, 2016-05-18 00:03:55]

LGTM with a better comment. Also, please update the description to indicate what
went wrong. I get it, but I shouldn't have to read the code to figure out what
is causing the problem.

https://codereview.chromium.org/1986963003/diff/1/ui/wm/core/window_animation...
File ui/wm/core/window_animations.cc (right):

https://codereview.chromium.org/1986963003/diff/1/ui/wm/core/window_animation...
ui/wm/core/window_animations.cc:106: // Reset the transform for the window_ so
that window's bound is represent
nit: |window_| (just as on line 80 and 81).
Also, 'is represent the correct value' doesn't make sense. I think you want
something like, 'The animation may have changed the transform, when recreating
the layers we need to reset the transform otherwise the recreated layer has the
transform installed for the animation.'

[Qiang(Joe) Xu, 2016-05-18 00:19:35]

Description was changed from

==========
Apps window keeps moving down to the right when reopened

BUG=602661
TEST=add unittest in visibility_controller
==========

to

==========
Hide animation may have changed the transform, when recreating layer if we don't
reset the transform, the installed transform from last hiding animation (such as
a closing window operation) will cause window bounds changed. 

BUG=602661
TEST=add unittest in visibility_controller
==========

[Qiang(Joe) Xu, 2016-05-18 00:20:24]

On 2016/05/18 00:03:55, sky wrote:
> LGTM with a better comment. Also, please update the description to indicate
what
> went wrong. I get it, but I shouldn't have to read the code to figure out what
> is causing the problem.
> 
>
https://codereview.chromium.org/1986963003/diff/1/ui/wm/core/window_animation...
> File ui/wm/core/window_animations.cc (right):
> 
>
https://codereview.chromium.org/1986963003/diff/1/ui/wm/core/window_animation...
> ui/wm/core/window_animations.cc:106: // Reset the transform for the window_ so
> that window's bound is represent
> nit: |window_| (just as on line 80 and 81).
> Also, 'is represent the correct value' doesn't make sense. I think you want
> something like, 'The animation may have changed the transform, when recreating
> the layers we need to reset the transform otherwise the recreated layer has
the
> transform installed for the animation.'

tks : ). updated description and comment.

[Qiang(Joe) Xu, 2016-05-18 05:01:56]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2016-05-18 05:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1986963003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 05:02:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1986963003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1986963003/20001

[commit-bot: I haz the power, 2016-05-18 06:10:30]

Description was changed from

==========
Hide animation may have changed the transform, when recreating layer if we don't
reset the transform, the installed transform from last hiding animation (such as
a closing window operation) will cause window bounds changed. 

BUG=602661
TEST=add unittest in visibility_controller
==========

to

==========
Hide animation may have changed the transform, when recreating layer if we don't
reset the transform, the installed transform from last hiding animation (such as
a closing window operation) will cause window bounds changed. 

BUG=602661
TEST=add unittest in visibility_controller
==========

[commit-bot: I haz the power, 2016-05-18 06:10:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 06:11:48]

Description was changed from

==========
Hide animation may have changed the transform, when recreating layer if we don't
reset the transform, the installed transform from last hiding animation (such as
a closing window operation) will cause window bounds changed. 

BUG=602661
TEST=add unittest in visibility_controller
==========

to

==========
Hide animation may have changed the transform, when recreating layer if we don't
reset the transform, the installed transform from last hiding animation (such as
a closing window operation) will cause window bounds changed.

BUG=602661
TEST=add unittest in visibility_controller

Committed: https://crrev.com/ac95109db90a079c1d56bc61b5a2b27b2b2fae63
Cr-Commit-Position: refs/heads/master@{#394340}
==========

[commit-bot: I haz the power, 2016-05-18 06:11:49]

Patchset 2 (id:??) landed as
https://crrev.com/ac95109db90a079c1d56bc61b5a2b27b2b2fae63
Cr-Commit-Position: refs/heads/master@{#394340}