Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 202050: Disallow popup windows from setting the window size to the exact (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disallow popup windows from setting the window size to the exact screen size. This works around a WM work around that causes the popup to end up in full screen mode. BUG=21456 TEST=Go to www.stonephotography.ca, click on enter site, verify that the window is not in full screen mode (over taskbar).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/browser/gtk/browser_window_gtk.cc View 3 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 3 months ago (2009-09-10 21:21:41 UTC) #1
Daniel Erat
11 years, 3 months ago (2009-09-10 21:53:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698