Disallow popup windows from setting the window size to the exact

chrome/browser/gtk/browser_window_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/browser_window_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
 #include <string>
@@ skipping 499 matching lines @@
     default:
       NOTREACHED();
   }
   return GDK_LAST_CURSOR;
 }
 
 GdkColor SkColorToGdkColor(const SkColor& color) {
   return skia::SkColorToGdkColor(color);
 }
 
+// A helper method for setting the GtkWindow size that should be used in place
+// of calling gtk_window_resize directly.  This is done to avoid a WM "feature"
+// where setting the window size to the screen size causes the WM to set the
+// EWMH for full screen mode.
+void SetWindowSize(GtkWindow* window, int width, int height) {
+  GdkScreen* screen = gdk_screen_get_default();
+  if (width == gdk_screen_get_width(screen) &&
+      height == gdk_screen_get_height(screen)) {
+    // Adjust the height so we don't trigger the WM feature.
+    gtk_window_resize(window, width, height - 1);
+  } else {
+    gtk_window_resize(window, width, height);
+  }
+}
+
 }  // namespace
 
 std::map<XID, GtkWindow*> BrowserWindowGtk::xid_map_;
 
 #if defined(OS_CHROMEOS)
 // Default to using the regular window style.
 bool BrowserWindowGtk::next_window_should_use_compact_nav_ = false;
 #endif
 
 BrowserWindowGtk::BrowserWindowGtk(Browser* browser)
@@ skipping 263 matching lines @@
   }
 }
 
 void BrowserWindowGtk::SetBounds(const gfx::Rect& bounds) {
   gint x = static_cast<gint>(bounds.x());
   gint y = static_cast<gint>(bounds.y());
   gint width = static_cast<gint>(bounds.width());
   gint height = static_cast<gint>(bounds.height());
 
   gtk_window_move(window_, x, y);
-  gtk_window_resize(window_, width, height);
+  SetWindowSize(window_, width, height);
 }
 
 void BrowserWindowGtk::Close() {
   // We're already closing.  Do nothing.
   if (!window_)
     return;
 
   if (!CanClose())
     return;
 
@@ skipping 621 matching lines @@
   // on the window and we intentionally *don't* do that for normal
   // windows.  We tested many programs and none of them restored their
   // position on Linux.
   //
   // However, in cases like dropping a tab where the bounds are
   // specifically set, we do want to position explicitly.
   if (browser_->bounds_overridden()) {
     SetBounds(bounds);
   } else {
     // Ignore the position but obey the size.
-    GdkScreen* screen = gdk_screen_get_default();
-    if (bounds.width() == gdk_screen_get_width(screen) &&
-        bounds.height() == gdk_screen_get_height(screen)) {
-      // Work around a WM "feature" where if we set the window to the exact
-      // size of the monitor, the WM automatically puts us in full screen mode.
-      // Instead, adjust the height so we don't trigger this WM work around.
-      gtk_window_resize(window_, bounds.width(), bounds.height() - 1);
-    } else {
-      gtk_window_resize(window_, bounds.width(), bounds.height());
-    }
+    SetWindowSize(window_, bounds.width(), bounds.height());
   }
 }
 
 void BrowserWindowGtk::ConnectHandlersToSignals() {
   g_signal_connect(window_, "delete-event",
                    G_CALLBACK(MainWindowDeleteEvent), this);
   g_signal_connect(window_, "destroy",
                    G_CALLBACK(MainWindowDestroy), this);
   g_signal_connect(window_, "configure-event",
                    G_CALLBACK(MainWindowConfigured), this);
@@ skipping 688 matching lines @@
   // special-case the ones where the custom frame should be used.  These names
   // are taken from the WMs' source code.
   return (wm_name == "Blackbox" ||
           wm_name == "compiz" ||
           wm_name == "e16" ||  // Enlightenment DR16
           wm_name == "KWin" ||
           wm_name == "Metacity" ||
           wm_name == "Openbox" ||
           wm_name == "Xfwm4");
 }