Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2020453003: Convert ViewProviderApp and ContentViewerApp to implement ApplicationImplBase instead of Applicatio… (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work796_no_run_main_app
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Convert ViewProviderApp and ContentViewerApp to implement ApplicationImplBase instead of ApplicationDelegate. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8f8c21556bb8bc6ee96d310b1e6d892302b0bfc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -80 lines) Patch
M apps/moterm/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M apps/moterm/moterm_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M examples/shadows/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M examples/shadows/shadows_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/jank/jank.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M examples/ui/noodles/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M examples/ui/noodles/noodles_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/pdf_viewer/pdf_viewer.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M examples/ui/png_viewer/png_viewer.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M examples/ui/shapes/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M examples/ui/shapes/shapes_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/spinning_cube/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M examples/ui/spinning_cube/spinning_cube_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/tile/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M examples/ui/tile/tile_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/ui/content_viewer_app.h View 4 chunks +17 lines, -11 lines 0 comments Download
M mojo/ui/content_viewer_app.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M mojo/ui/view_provider_app.h View 3 chunks +8 lines, -12 lines 0 comments Download
M mojo/ui/view_provider_app.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2011383002 Patch 1

Dependent Patchsets:

Issue 2015363003 Patch 1
Issue 2015363003 Patch 20001
Issue 2015363003 Patch 40001
Issue 2015363003 Patch 60001
Issue 2015363003 Patch 80001

Messages

Total messages: 5 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2011383002/.
4 years, 6 months ago (2016-05-27 20:05:03 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-05-31 16:53:02 UTC) #2
vardhan
lgtm
4 years, 6 months ago (2016-05-31 19:48:49 UTC) #3
viettrungluu
4 years, 6 months ago (2016-05-31 20:11:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8f8c21556bb8bc6ee96d310b1e6d892302b0bfc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698