Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2020363002: Revert of [heap] Do not invoke GC to make heap iterable. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Do not invoke GC to make heap iterable. (patchset #3 id:40001 of https://codereview.chromium.org/1992913004/ ) Reason for revert: [Sheriff] Speculative revert for some flakes on the waterfall: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/7409 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/7983 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/4901 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > This reverts commit 0aa3707dc403a5285d216b01d24faa27375ceec4. > > And removes the UnreachableObjectsFilter. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/132f89800f560190b4d655adcb4e0eeedd17fd82 > Cr-Commit-Position: refs/heads/master@{#36617} TBR=yangguo@chromium.org,ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Committed: https://crrev.com/72f7d9a294451f2cb228fa3a6ae06eab1cf8d7e2 Cr-Commit-Position: refs/heads/master@{#36622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -47 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.h View 6 chunks +28 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +109 lines, -12 lines 0 comments Download
M src/log.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M src/profiler/heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-referenced-by.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Do not invoke GC to make heap iterable.
4 years, 6 months ago (2016-05-31 17:40:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020363002/1
4 years, 6 months ago (2016-05-31 17:40:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 17:40:33 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:43:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72f7d9a294451f2cb228fa3a6ae06eab1cf8d7e2
Cr-Commit-Position: refs/heads/master@{#36622}

Powered by Google App Engine
This is Rietveld 408576698