src/profiler/heap-profiler.cc - Issue 2020363002: Revert of [heap] Do not invoke GC to make heap iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-profiler.cc

Issue 2020363002: Revert of [heap] Do not invoke GC to make heap iterable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/heap-profiler.cc

diff --git a/src/profiler/heap-profiler.cc b/src/profiler/heap-profiler.cc

index d01a15b040138ab417e4c1fda507ed049aad3c89..e048faece5401e7deacb41bf09ee2c73cefc0271 100644

--- a/src/profiler/heap-profiler.cc

+++ b/src/profiler/heap-profiler.cc

@@ -198,7 +198,7 @@

Handle<HeapObject> HeapProfiler::FindHeapObjectById(SnapshotObjectId id) {

HeapObject* object = NULL;

- HeapIterator iterator(heap(), HeapObjectsFiltering::kFilterUnreachable);

+ HeapIterator iterator(heap(), HeapIterator::kFilterUnreachable);

// Make sure that object with the given id is still reachable.

for (HeapObject* obj = iterator.next();

obj != NULL;

« no previous file with comments | « src/log.cc ('k') | src/profiler/heap-snapshot-generator.h » ('j') | no next file with comments »