third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h - Issue 2020313002: Verify the order of RawResourceClient callbacks in DocumentThreadableLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 2020313002: Verify the order of RawResourceClient callbacks in DocumentThreadableLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/RawResource.h ('K') | « third_party/WebKit/Source/core/fetch/RawResource.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

index e0eda8ef6577bda01238416f7b50fd365c6e4727..f919db7cf53293872db0d6658c636f9fe4c0cd62 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

@@ -161,11 +161,14 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

if (newResource == m_resource)

return;

- if (RawResource* oldResource = m_resource.release())

+ if (RawResource* oldResource = m_resource.release()) {

+ m_checker.willRemoveClient();

oldResource->removeClient(this);

+ }

if (newResource) {

m_resource = newResource;

+ m_checker.willAddClient();

m_resource->addClient(this);

}

@@ -225,6 +228,8 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

WebURLRequest::FetchRedirectMode m_redirectMode;

+ RawResourceClientStateChecker m_checker;

WeakPtrFactory<DocumentThreadableLoader> m_weakFactory;

};