Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 2020313002: Verify the order of RawResourceClient callbacks in DocumentThreadableLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index bce49a4842d27df9c2fad6cc099b6060a85096ca..9976f505d906aa05f6ecf869545a8082bdb06cc1 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -425,6 +425,8 @@ void DocumentThreadableLoader::redirectReceived(Resource* resource, ResourceRequ
ASSERT_UNUSED(resource, resource == this->resource());
ASSERT(m_async);
+ m_checker.redirectReceived();
+
if (!m_actualRequest.isNull()) {
reportResponseReceived(resource->identifier(), redirectResponse);
@@ -558,6 +560,8 @@ void DocumentThreadableLoader::redirectReceived(Resource* resource, ResourceRequ
void DocumentThreadableLoader::redirectBlocked()
{
+ m_checker.redirectBlocked();
+
// Tells the client that a redirect was received but not followed (for an unknown reason).
ThreadableLoaderClient* client = m_client;
clear();
@@ -571,6 +575,7 @@ void DocumentThreadableLoader::dataSent(Resource* resource, unsigned long long b
ASSERT_UNUSED(resource, resource == this->resource());
ASSERT(m_async);
+ m_checker.dataSent();
m_client->didSendData(bytesSent, totalBytesToBeSent);
// |this| may be dead here.
}
@@ -582,6 +587,7 @@ void DocumentThreadableLoader::dataDownloaded(Resource* resource, int dataLength
ASSERT(m_actualRequest.isNull());
ASSERT(m_async);
+ m_checker.dataDownloaded();
m_client->didDownloadData(dataLength);
// |this| may be dead here.
}
@@ -601,6 +607,8 @@ void DocumentThreadableLoader::responseReceived(Resource* resource, const Resour
ASSERT_UNUSED(resource, resource == this->resource());
ASSERT(m_async);
+ m_checker.responseReceived();
+
if (handle)
m_isUsingDataConsumerHandle = true;
@@ -714,6 +722,8 @@ void DocumentThreadableLoader::handleResponse(unsigned long identifier, const Re
void DocumentThreadableLoader::setSerializedCachedMetadata(Resource*, const char* data, size_t size)
{
+ m_checker.setSerializedCachedMetadata();
+
if (!m_actualRequest.isNull())
return;
m_client->didReceiveCachedMetadata(data, size);
@@ -725,6 +735,8 @@ void DocumentThreadableLoader::dataReceived(Resource* resource, const char* data
ASSERT_UNUSED(resource, resource == this->resource());
ASSERT(m_async);
+ m_checker.dataReceived();
+
if (m_isUsingDataConsumerHandle)
return;
@@ -754,6 +766,8 @@ void DocumentThreadableLoader::notifyFinished(Resource* resource)
ASSERT(resource == this->resource());
ASSERT(m_async);
+ m_checker.notifyFinished(resource);
+
if (resource->errorOccurred()) {
handleError(resource->resourceError());
// |this| may be dead here.

Powered by Google App Engine
This is Rietveld 408576698