Use mus::MojoGpuMemoryBufferManager in mus::GpuService.

Use mus::MojoGpuMemoryBufferManager in mus::GpuService.

BUG=586390
Committed: https://crrev.com/7948bc432a3312c87d9a0c8672f2a526f29ffa27
Cr-Commit-Position: refs/heads/master@{#398130}

[Peng, 2016-06-01 15:35:27]

penghuang@chromium.org changed reviewers:
+ piman@chromium.org

[Peng, 2016-06-01 15:35:28]

Hi Antoine, PTAL. Thanks.

[piman, 2016-06-03 21:02:31]

lgtm

https://codereview.chromium.org/2020293003/diff/20001/components/mus/gpu/gpu_...
File components/mus/gpu/gpu_service_impl.cc (right):

https://codereview.chromium.org/2020293003/diff/20001/components/mus/gpu/gpu_...
components/mus/gpu/gpu_service_impl.cc:34: // TODO(penghuang): figure out how to
generate a meaningful tracing id.
The important part is that the tracing ID given to the GPU process is the same
as the tracing ID used for tracing, or other allocations done on behalf of the
connecting process.
This is so we can correctly attribute memory to the process. This needs to be
thought about more generally in the mus design. Maybe file a bug?

[Peng, 2016-06-06 13:24:58]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2016-06-06 13:24:59]

Hi Scott, PTAL. Thanks.

[Peng, 2016-06-06 14:10:33]

https://codereview.chromium.org/2020293003/diff/20001/components/mus/gpu/gpu_...
File components/mus/gpu/gpu_service_impl.cc (right):

https://codereview.chromium.org/2020293003/diff/20001/components/mus/gpu/gpu_...
components/mus/gpu/gpu_service_impl.cc:34: // TODO(penghuang): figure out how to
generate a meaningful tracing id.
On 2016/06/03 21:02:31, piman OOO back 2016-6-2 wrote:
> The important part is that the tracing ID given to the GPU process is the same
> as the tracing ID used for tracing, or other allocations done on behalf of the
> connecting process.
> This is so we can correctly attribute memory to the process. This needs to be
> thought about more generally in the mus design. Maybe file a bug?

Filed a bug. Done

[sky, 2016-06-06 17:06:26]

LGTM

https://codereview.chromium.org/2020293003/diff/60001/components/mus/common/g...
File components/mus/common/gpu_service.h (right):

https://codereview.chromium.org/2020293003/diff/60001/components/mus/common/g...
components/mus/common/gpu_service.h:51: base::Lock lock_;
Please add a comment as to why you need the lock.

[Peng, 2016-06-06 17:16:41]

https://codereview.chromium.org/2020293003/diff/60001/components/mus/common/g...
File components/mus/common/gpu_service.h (right):

https://codereview.chromium.org/2020293003/diff/60001/components/mus/common/g...
components/mus/common/gpu_service.h:51: base::Lock lock_;
On 2016/06/06 17:06:25, sky wrote:
> Please add a comment as to why you need the lock.

Done.

[Peng, 2016-06-06 17:17:40]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-06-06 17:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2020293003/#ps80001
(title: "Update")

[commit-bot: I haz the power, 2016-06-06 17:18:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020293003/80001

[commit-bot: I haz the power, 2016-06-06 21:24:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-06 21:27:06]

Description was changed from

==========
Use mus::MojoGpuMemoryBufferManager in mus::GpuService.


BUG=586390
==========

to

==========
Use mus::MojoGpuMemoryBufferManager in mus::GpuService.

BUG=586390

Committed: https://crrev.com/7948bc432a3312c87d9a0c8672f2a526f29ffa27
Cr-Commit-Position: refs/heads/master@{#398130}
==========

[commit-bot: I haz the power, 2016-06-06 21:27:07]

Patchset 5 (id:??) landed as
https://crrev.com/7948bc432a3312c87d9a0c8672f2a526f29ffa27
Cr-Commit-Position: refs/heads/master@{#398130}