Issue 2020273003: Added popup that shows the new Back shortcut on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2020273003: Added popup that shows the new Back shortcut on Mac. (Closed)

Created:
4 years, 6 months ago by Matt Giuca

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Added popup that shows the new Back shortcut on Mac. Implements BrowserWindowCocoa::ShowNewBackShortcutBubble to open the Views implementation of this bubble (similar to how the fullscreen bubble works on Mac). BUG=610039 Review-Url: https://codereview.chromium.org/2017813004 Cr-Commit-Position: refs/heads/master@{#396759} (cherry picked from commit d8fdd17d87b906d6a0e21bd6366dface55132440) Committed: https://chromium.googlesource.com/chromium/src/+/3afb8b628beb3c3f63719df77d3e4e46ddb86818

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Matt Giuca

4 years, 6 months ago (2016-06-01 08:09:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3afb8b628beb3c3f63719df77d3e4e46ddb86818.