Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2017813004: Added popup that shows the new Back shortcut on Mac. (Closed)

Created:
4 years, 6 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, Peter Kasting, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@backspace-new-shortcut-bubble
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added popup that shows the new Back shortcut on Mac. Implements BrowserWindowCocoa::ShowNewBackShortcutBubble to open the Views implementation of this bubble (similar to how the fullscreen bubble works on Mac). BUG=610039 Committed: https://crrev.com/d8fdd17d87b906d6a0e21bd6366dface55132440 Cr-Commit-Position: refs/heads/master@{#396759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Matt Giuca
It's Mac time!
4 years, 6 months ago (2016-05-30 07:29:55 UTC) #2
tapted
lgtm
4 years, 6 months ago (2016-05-30 11:02:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017813004/1
4 years, 6 months ago (2016-05-31 00:19:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 00:22:57 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 00:24:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8fdd17d87b906d6a0e21bd6366dface55132440
Cr-Commit-Position: refs/heads/master@{#396759}

Powered by Google App Engine
This is Rietveld 408576698