Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 2020273002: Unbreak build after https://codereview.chromium.org/2017853002 (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbreak build after https://codereview.chromium.org/2017853002 Should fix: FAILED: install_static_unittests.isolated.gen.json C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper environment.x86 install_static_unittests_run_target_isolate_505e5a847558b720a0ef83d1cbafd202.8c6a326aa7c39f12a19f31e474b8425f.rsp ..\..\chrome Traceback (most recent call last): File "../tools/isolate_driver.py", line 313, in <module> sys.exit(main()) File "../tools/isolate_driver.py", line 297, in main create_wrapper(args, isolate, isolated) File "../tools/isolate_driver.py", line 212, in create_wrapper assert os.path.basename(isolate) == isolate, isolate AssertionError: install_static\install_static_unittests.isolate BUG=604923 TBR=ananta Committed: https://chromium.googlesource.com/chromium/src/+/b813c7c46b9c584201dad05da1121fc06314578a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/chrome_installer_static.gypi View 1 chunk +1 line, -1 line 0 comments Download
D chrome/install_static/install_static_unittests.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
A + chrome/install_static_unittests.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
4 years, 6 months ago (2016-05-31 14:05:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020273002/1
4 years, 6 months ago (2016-05-31 14:08:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b813c7c46b9c584201dad05da1121fc06314578a Cr-Commit-Position: refs/heads/master@{#396825}
4 years, 6 months ago (2016-05-31 14:20:51 UTC) #7
Nico
Committed patchset #1 (id:1) manually as b813c7c46b9c584201dad05da1121fc06314578a (presubmit successful).
4 years, 6 months ago (2016-05-31 14:21:37 UTC) #9
ananta
lgtm thanks for fixing.
4 years, 6 months ago (2016-05-31 18:30:01 UTC) #10
ananta
4 years, 6 months ago (2016-05-31 18:30:03 UTC) #11
Message was sent while issue was closed.
lgtm

thanks for fixing.

Powered by Google App Engine
This is Rietveld 408576698