Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2020253002: [Loader] Add asserts about revalidation and redirects (Closed)

Created:
4 years, 6 months ago by hiroshige
Modified:
4 years, 6 months ago
Reviewers:
kinuko, Nate Chapin, yhirano
CC:
tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Loader] Add asserts about revalidation and redirects After https://codereview.chromium.org/2011283002/ and https://codereview.chromium.org/2017883002/, redirect chain must be empty when revalidation starts or during revalidation is ongoing. This CL adds asserts to verify that. BUG=613971, 614989 Committed: https://crrev.com/d0753f72046d160bc34584a47eb3f3a3c56daff1 Cr-Commit-Position: refs/heads/master@{#397683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/Resource.cpp View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
hiroshige
PTAL. I'm planning to merge this CL to beta/stable.
4 years, 6 months ago (2016-05-31 13:53:28 UTC) #4
Nate Chapin
lgtm
4 years, 6 months ago (2016-05-31 19:07:52 UTC) #5
kinuko
lgtm/2
4 years, 6 months ago (2016-06-01 00:26:18 UTC) #6
yhirano
lgtm
4 years, 6 months ago (2016-06-03 02:02:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020253002/1
4 years, 6 months ago (2016-06-03 09:42:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 11:28:31 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 11:29:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0753f72046d160bc34584a47eb3f3a3c56daff1
Cr-Commit-Position: refs/heads/master@{#397683}

Powered by Google App Engine
This is Rietveld 408576698