Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2020253002: [Loader] Add asserts about revalidation and redirects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index 797393003558096ec18e1e5dbc864c64dfc0c425..aab395943d7735587c6d4757f54c6af735c81441 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -545,6 +545,7 @@ const ResourceRequest& Resource::lastResourceRequest() const
void Resource::setRevalidatingRequest(const ResourceRequest& request)
{
+ SECURITY_CHECK(m_redirectChain.isEmpty());
m_revalidatingRequest = request;
m_status = NotStarted;
}
@@ -896,6 +897,8 @@ String Resource::getMemoryDumpName() const
void Resource::revalidationSucceeded(const ResourceResponse& validatingResponse)
{
+ SECURITY_CHECK(m_redirectChain.isEmpty());
+ SECURITY_CHECK(validatingResponse.url() == m_response.url());
m_response.setResourceLoadTiming(validatingResponse.resourceLoadTiming());
// RFC2616 10.3.5
@@ -920,7 +923,7 @@ void Resource::revalidationFailed()
{
m_resourceRequest = m_revalidatingRequest;
m_revalidatingRequest = ResourceRequest();
- m_redirectChain.clear();
+ SECURITY_CHECK(m_redirectChain.isEmpty());
m_data.clear();
m_cacheHandler.clear();
destroyDecodedDataForFailedRevalidation();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698