core/fpdfapi/fpdf_page/fpdf_page_parser.cpp - Issue 2020183004: Validate the BitsPerFlag entry in shading dictionaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

Issue 2020183004: Validate the BitsPerFlag entry in shading dictionaries. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@bug_616246

Patch Set: Add check Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

index ddea2e653d7aeafef59c0013a609891abcc81240..0592c97176d8a3445d69d82510e0795bf74b567b 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

@@ -106,8 +106,8 @@ CFX_FloatRect GetShadingBBox(CPDF_ShadingPattern* pShading,

if (!pStream || !pCS)

return CFX_FloatRect(0, 0, 0, 0);

- CPDF_MeshStream stream(pShading->GetFuncs(), pCS);

- if (!stream.Load(pStream))

+ CPDF_MeshStream stream(type, pShading->GetFuncs(), pStream, pCS);

+ if (!stream.Load())

return CFX_FloatRect(0, 0, 0, 0);

CFX_FloatRect rect;