Issue 2020153002: Move ScriptResourceClient to Oilpan heap

Issue 2020153002: Move ScriptResourceClient to Oilpan heap (Closed)

Created:
4 years, 6 months ago by yhirano

Modified:
4 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src.git@onheap-font-resource-client

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move ScriptResourceClient to Oilpan heap BUG=587663 Committed: https://crrev.com/9bcbe1504190d09f24a775e75951e940daea6035 Cr-Commit-Position: refs/heads/master@{#397148}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -34 lines)			Patch
M	third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp	View	1 2	17 chunks	+33 lines, -32 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/PendingScript.h	View		1 chunk	+1 line, -1 line	1 comment	Download
M	third_party/WebKit/Source/core/dom/PendingScript.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/ScriptLoader.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/ScriptLoader.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/ScriptResource.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2014533002 Patch 80001

Messages

Total messages: 12 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

yhirano

https://codereview.chromium.org/2020153002/diff/40001/third_party/WebKit/Source/core/dom/PendingScript.h File third_party/WebKit/Source/core/dom/PendingScript.h (right): https://codereview.chromium.org/2020153002/diff/40001/third_party/WebKit/Source/core/dom/PendingScript.h#newcode98 third_party/WebKit/Source/core/dom/PendingScript.h:98: Member<ScriptResourceClient> m_client; As this class's user has already needed ...

4 years, 6 months ago (2016-06-01 08:39:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020153002/40001

4 years, 6 months ago (2016-06-01 12:23:51 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/79770)

4 years, 6 months ago (2016-06-01 13:58:53 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020153002/40001

4 years, 6 months ago (2016-06-01 14:32:10 UTC) #9

commit-bot: I haz the power

4 years, 6 months ago (2016-06-01 15:29:56 UTC) #12

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/9bcbe1504190d09f24a775e75951e940daea6035
Cr-Commit-Position: refs/heads/master@{#397148}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages