Move FontResourceClient to Oilpan heap

Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin
subclass.

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
Committed: https://crrev.com/edf0f13e96321b2551d06832d59704d554aac4ba
Cr-Commit-Position: refs/heads/master@{#397045}

[yhirano, 2016-05-25 11:19:40]

Description was changed from

==========
Move FontResourceClient to Oilpan heap

BUG=587663
==========

to

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient GarbageCollectedMixin. 

Registering a prefinalizer in a class T is not possible when

 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

[yhirano, 2016-05-25 11:19:52]

Description was changed from

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient GarbageCollectedMixin. 

Registering a prefinalizer in a class T is not possible when

 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

to

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient GarbageCollectedMixin. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

[yhirano, 2016-05-25 11:20:11]

Description was changed from

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient GarbageCollectedMixin. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

to

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin subclass. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

[yhirano, 2016-05-25 11:20:23]

Description was changed from

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin subclass. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

to

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin
subclass. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

[yhirano, 2016-05-25 12:42:08]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org, japhet@chromium.org, oilpan-reviews@chromium.org

[haraken, 2016-05-25 17:53:53]

Hmm, ResourceOwner is going to be very complicated...

Alternately, would it be possible to make FontResourceClient inherit from
ResourceOwner? (Our plan is to make all ResourceClients inherit from
ResourceOwner in the end.)

[yhirano, 2016-05-26 02:33:38]

On 2016/05/25 17:53:53, haraken wrote:
> Hmm, ResourceOwner is going to be very complicated...
> 
> Alternately, would it be possible to make FontResourceClient inherit from
> ResourceOwner?

That requires us to change a lot of ResourceClient subclasses, I guess.
ResourceOwner's responsibility doesn't change by this CL and I prefer having two
kinds of ResourceOwner to modifying ResourceClient subclasses.

> (Our plan is to make all ResourceClients inherit from ResourceOwner in the
end.)
As said at https://codereview.chromium.org/1996293002/#msg10 I'm hoping we won't
need removeClient in the long run and that will affect the ideal design.
Anyway, such design changes will be done more easily when all ResourceClients
become GarbageCollectedMixin.

[haraken, 2016-05-26 03:37:26]

Hmm, I'm a bit confused.

Why do you need the change in ResourceOwner.h in the first place? Neither
RemoteFontFaceSource nor FontResourceClient inherits from ResourceOwner.
RemoteFontFaceSource's pre-finalizer is calling removeClient, which will just
work fine...

[yhirano, 2016-05-26 03:43:27]

On 2016/05/26 03:37:26, haraken wrote:
> Hmm, I'm a bit confused.
> 
> Why do you need the change in ResourceOwner.h in the first place? Neither
> RemoteFontFaceSource nor FontResourceClient inherits from ResourceOwner.
> RemoteFontFaceSource's pre-finalizer is calling removeClient, which will just
> work fine...

ResourceOwner<FontResource> is a subclass of FontResourceClient.
LinkPreloadStyleResourceClient and FontResourceHelper are
ResourceOwner<FontResource>'s subclasses. Please see compile errors for PS1.

[haraken, 2016-05-26 03:55:55]

On 2016/05/26 03:43:27, yhirano wrote:
> On 2016/05/26 03:37:26, haraken wrote:
> > Hmm, I'm a bit confused.
> > 
> > Why do you need the change in ResourceOwner.h in the first place? Neither
> > RemoteFontFaceSource nor FontResourceClient inherits from ResourceOwner.
> > RemoteFontFaceSource's pre-finalizer is calling removeClient, which will
just
> > work fine...
> 
> ResourceOwner<FontResource> is a subclass of FontResourceClient.
> LinkPreloadStyleResourceClient and FontResourceHelper are
> ResourceOwner<FontResource>'s subclasses. Please see compile errors for PS1.

Thanks, I now understand the problem.

Yeah, it looks hard to avoid the hack in ResourceOwner.h in a transition period.
LGTM.

[yhirano, 2016-05-27 08:11:25]

hiroshige@ suggested a much smarter way (ResourceOwner in PS4). Thanks!

[hiroshige, 2016-05-27 08:18:38]

https://codereview.chromium.org/2014533002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceOwner.h (right):

https://codereview.chromium.org/2014533002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceOwner.h:39: template <typename R,
typename C, bool isClientGarbageCollectedMixin>
|R| is not necessary?

nit optional: How about renaming |C| to |Client|, to make it consistent with
|isClientGarbageCollectedMixin|?

[haraken, 2016-05-27 08:20:19]

Yeah, PS4 looks much simpler!

[yhirano, 2016-05-27 16:37:28]

https://codereview.chromium.org/2014533002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceOwner.h (right):

https://codereview.chromium.org/2014533002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceOwner.h:39: template <typename R,
typename C, bool isClientGarbageCollectedMixin>
On 2016/05/27 08:18:38, hiroshige wrote:
> |R| is not necessary?
> 
> nit optional: How about renaming |C| to |Client|, to make it consistent with
> |isClientGarbageCollectedMixin|?

Done.

[hiroshige, 2016-05-31 11:51:27]

lgtm.

[yhirano, 2016-06-01 01:15:00]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-06-01 01:15:01]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2014533002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-06-01 01:15:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014533002/80001

[commit-bot: I haz the power, 2016-06-01 03:51:56]

Description was changed from

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin
subclass. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

to

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin
subclass. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

[commit-bot: I haz the power, 2016-06-01 03:51:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-01 03:53:09]

Description was changed from

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin
subclass. 

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663
==========

to

==========
Move FontResourceClient to Oilpan heap

This change makes FontResourceClient a GarbageCollectedMixin
subclass.

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663

Committed: https://crrev.com/edf0f13e96321b2551d06832d59704d554aac4ba
Cr-Commit-Position: refs/heads/master@{#397045}
==========

[commit-bot: I haz the power, 2016-06-01 03:53:10]

Patchset 5 (id:??) landed as
https://crrev.com/edf0f13e96321b2551d06832d59704d554aac4ba
Cr-Commit-Position: refs/heads/master@{#397045}