Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2020133002: Reland of Suppress UNINITIALIZED READ in blink platform test (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
Ilya Kulshin, oshima
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, Irfan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Suppress UNINITIALIZED READ in blink platform test (patchset #2 id:40001 of https://codereview.chromium.org/2002323002/ ) Reason for revert: Still a problem. Original issue's description: > Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) > > Reason for revert: > Removing the suppression to determine if this is still a > problem. I'm unable to reproduce the error locally. > http://chromium-build-logs.appspot.com/suppression_query > also suggests this suppression is no longer needed. > > Original issue's description: > > Suppress UNINITIALIZED READ in blink platform test > > > > BUG=608111 > > TBR=kulshin@chromium.org, > > > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > > Cr-Commit-Position: refs/heads/master@{#390822} > > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=608111 > > Committed: https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce > Cr-Commit-Position: refs/heads/master@{#395975} TBR=oshima@chromium.org,kulshin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 Committed: https://crrev.com/7545bb204f767f0c076377bfea29972623efcfb2 Cr-Commit-Position: refs/heads/master@{#396767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
Created Reland of Suppress UNINITIALIZED READ in blink platform test
4 years, 6 months ago (2016-05-31 01:46:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020133002/1
4 years, 6 months ago (2016-05-31 01:46:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 02:24:38 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 02:26:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7545bb204f767f0c076377bfea29972623efcfb2
Cr-Commit-Position: refs/heads/master@{#396767}

Powered by Google App Engine
This is Rietveld 408576698