Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2002323002: Revert of Suppress UNINITIALIZED READ in blink platform test (Closed)

Created:
4 years, 7 months ago by Ilya Kulshin
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, oshima
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, Irfan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 Committed: https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce Cr-Commit-Position: refs/heads/master@{#395975}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Ilya Kulshin
Created Revert of Suppress UNINITIALIZED READ in blink platform test
4 years, 7 months ago (2016-05-23 21:18:10 UTC) #1
Ilya Kulshin
ptal
4 years, 7 months ago (2016-05-23 21:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002323002/40001
4 years, 7 months ago (2016-05-23 21:53:29 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-23 21:53:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002323002/40001
4 years, 7 months ago (2016-05-23 21:54:22 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-23 21:54:24 UTC) #13
oshima
lgtm
4 years, 7 months ago (2016-05-25 19:11:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002323002/40001
4 years, 7 months ago (2016-05-25 19:20:22 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-25 20:16:49 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce Cr-Commit-Position: refs/heads/master@{#395975}
4 years, 7 months ago (2016-05-25 20:19:04 UTC) #20
Lei Zhang
It's still a problem: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/7357
4 years, 6 months ago (2016-05-31 01:45:43 UTC) #22
Lei Zhang
4 years, 6 months ago (2016-05-31 01:46:06 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2020133002/ by thestig@chromium.org.

The reason for reverting is: Still a problem..

Powered by Google App Engine
This is Rietveld 408576698