|
|
Created:
4 years, 7 months ago by Ilya Kulshin Modified:
4 years, 6 months ago CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, Irfan Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ )
Reason for revert:
Removing the suppression to determine if this is still a
problem. I'm unable to reproduce the error locally.
http://chromium-build-logs.appspot.com/suppression_query
also suggests this suppression is no longer needed.
Original issue's description:
> Suppress UNINITIALIZED READ in blink platform test
>
> BUG=608111
> TBR=kulshin@chromium.org,
>
> Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8
> Cr-Commit-Position: refs/heads/master@{#390822}
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=608111
Committed: https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce
Cr-Commit-Position: refs/heads/master@{#395975}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 23 (11 generated)
Created Revert of Suppress UNINITIALIZED READ in blink platform test
Description was changed from ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} TBR=oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ========== to ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} TBR=oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ==========
ptal
The CQ bit was checked by kulshin@chromium.org
The CQ bit was unchecked by kulshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002323002/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by kulshin@chromium.org
Description was changed from ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} TBR=oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ========== to ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002323002/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by kulshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002323002/40001
Message was sent while issue was closed.
Description was changed from ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ========== to ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 ========== to ========== Revert of Suppress UNINITIALIZED READ in blink platform test (patchset #1 id:1 of https://codereview.chromium.org/1940663002/ ) Reason for revert: Removing the suppression to determine if this is still a problem. I'm unable to reproduce the error locally. http://chromium-build-logs.appspot.com/suppression_query also suggests this suppression is no longer needed. Original issue's description: > Suppress UNINITIALIZED READ in blink platform test > > BUG=608111 > TBR=kulshin@chromium.org, > > Committed: https://crrev.com/93ac305579eaa690f7233542523f2eaa6f1fb8a8 > Cr-Commit-Position: refs/heads/master@{#390822} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608111 Committed: https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce Cr-Commit-Position: refs/heads/master@{#395975} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bf69f6e38876d892e8b6830117320420ce8274ce Cr-Commit-Position: refs/heads/master@{#395975}
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
It's still a problem: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2020133002/ by thestig@chromium.org. The reason for reverting is: Still a problem.. |