third_party/WebKit/Source/core/frame/FrameView.h - Issue 2020103002: Fix sticky constraints and update sticky layer positions recursively after scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2020103002: Fix sticky constraints and update sticky layer positions recursively after scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bugs with overflow scrollers in sticky position constraints, add unit tests, and test clipped b… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/sticky/sticky-clip-rel-child-expected.html ('K') | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.h

diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h

index d247ae99205dcf52081dcebd2b5c07510a1fd99f..d9523ba0b35e56ad972f255eed2a519727a48233 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.h

+++ b/third_party/WebKit/Source/core/frame/FrameView.h

@@ -715,7 +715,7 @@ private:

void scrollToFragmentAnchor();

void didScrollTimerFired(Timer<FrameView>*);

- void updateLayersAndCompositingAfterScrollIfNeeded();

+ void updateLayersAndCompositingAfterScrollIfNeeded(const DoubleSize& scrollDelta);

static bool computeCompositedSelection(LocalFrame&, CompositedSelection&);

void updateCompositedSelectionIfNeeded();