Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2020103002: Fix sticky constraints and update sticky layer positions recursively after scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bugs with overflow scrollers in sticky position constraints, add unit tests, and test clipped b… Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 708
709 void scheduleUpdateWidgetsIfNecessary(); 709 void scheduleUpdateWidgetsIfNecessary();
710 void updateWidgetsTimerFired(Timer<FrameView>*); 710 void updateWidgetsTimerFired(Timer<FrameView>*);
711 bool updateWidgets(); 711 bool updateWidgets();
712 712
713 bool processUrlFragmentHelper(const String&, UrlFragmentBehavior); 713 bool processUrlFragmentHelper(const String&, UrlFragmentBehavior);
714 void setFragmentAnchor(Node*); 714 void setFragmentAnchor(Node*);
715 void scrollToFragmentAnchor(); 715 void scrollToFragmentAnchor();
716 void didScrollTimerFired(Timer<FrameView>*); 716 void didScrollTimerFired(Timer<FrameView>*);
717 717
718 void updateLayersAndCompositingAfterScrollIfNeeded(); 718 void updateLayersAndCompositingAfterScrollIfNeeded(const DoubleSize& scrollD elta);
719 719
720 static bool computeCompositedSelection(LocalFrame&, CompositedSelection&); 720 static bool computeCompositedSelection(LocalFrame&, CompositedSelection&);
721 void updateCompositedSelectionIfNeeded(); 721 void updateCompositedSelectionIfNeeded();
722 722
723 // Returns true if the FrameView's own scrollbars overlay its content when v isible. 723 // Returns true if the FrameView's own scrollbars overlay its content when v isible.
724 bool hasOverlayScrollbars() const; 724 bool hasOverlayScrollbars() const;
725 725
726 // Returns true if the frame should use custom scrollbars. If true, one of 726 // Returns true if the frame should use custom scrollbars. If true, one of
727 // either |customScrollbarElement| or |customScrollbarFrame| will be set to 727 // either |customScrollbarElement| or |customScrollbarFrame| will be set to
728 // the element or frame which owns the scrollbar with the other set to null. 728 // the element or frame which owns the scrollbar with the other set to null.
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
938 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 938 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
939 setIsVisuallyNonEmpty(); 939 setIsVisuallyNonEmpty();
940 } 940 }
941 941
942 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 942 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
943 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView()); 943 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView());
944 944
945 } // namespace blink 945 } // namespace blink
946 946
947 #endif // FrameView_h 947 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698