Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2020023002:
Deprecate sign-in from share. (Closed)
DescriptionDeprecate sign-in from share.
In iOS7 and before, sharing could trigger the sign-in flow.
This is not possible anymore in iOS 9.
Downstream CL: https://chromereviews.googleplex.com/432527013/
BUG=608337
Committed: https://crrev.com/0c96540b3310595f91818ad186c0c017996dd314
Cr-Commit-Position: refs/heads/master@{#397475}
Patch Set 1 #Patch Set 2 : 2 #
Total comments: 3
Messages
Total messages: 19 (9 generated)
Description was changed from ========== Remove resharing code on iOS. BUG=608337 ========== to ========== Deprecate sign in from share. In iOS7 and before, sharing could trigger a sign in flow. This is not possible in iOS 8+. BUG=608337 ==========
Description was changed from ========== Deprecate sign in from share. In iOS7 and before, sharing could trigger a sign in flow. This is not possible in iOS 8+. BUG=608337 ========== to ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. BUG=608337 ==========
jif@chromium.org changed reviewers: + marq@chromium.org, msarda@chromium.org
jif@chromium.org changed reviewers: + sdefresne@chromium.org - marq@chromium.org, msarda@chromium.org
Description was changed from ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. BUG=608337 ========== to ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. Downstream CL: https://chromereviews.googleplex.com/432527013/ BUG=608337 ==========
ptal
https://codereview.chromium.org/2020023002/diff/20001/ios/chrome/browser/sign... File ios/chrome/browser/signin/constants.h (right): https://codereview.chromium.org/2020023002/diff/20001/ios/chrome/browser/sign... ios/chrome/browser/signin/constants.h:42: SIGN_IN_SOURCE_SHARE_DEPRECATED, We probably need to update Signin.IOSSignInSource history too, don't we?
jif@google.com changed reviewers: + jif@google.com
https://codereview.chromium.org/2020023002/diff/20001/ios/chrome/browser/sign... File ios/chrome/browser/signin/constants.h (right): https://codereview.chromium.org/2020023002/diff/20001/ios/chrome/browser/sign... ios/chrome/browser/signin/constants.h:42: SIGN_IN_SOURCE_SHARE_DEPRECATED, On 2016/05/30 14:16:29, sdefresne wrote: > We probably need to update Signin.IOSSignInSource history too, don't we? https://critique.corp.google.com/#review/123579885
lgtm
On 2016/06/02 17:05:59, jif-google wrote: > lgtm What I meant was: ping
The CQ bit was checked by sdefresne@chromium.org
lgtm https://codereview.chromium.org/2020023002/diff/20001/ios/chrome/browser/sign... File ios/chrome/browser/signin/constants.h (right): https://codereview.chromium.org/2020023002/diff/20001/ios/chrome/browser/sign... ios/chrome/browser/signin/constants.h:42: SIGN_IN_SOURCE_SHARE_DEPRECATED, On 2016/05/30 14:29:26, jif-google wrote: > On 2016/05/30 14:16:29, sdefresne wrote: > > We probably need to update Signin.IOSSignInSource history too, don't we? > > https://critique.corp.google.com/#review/123579885 As the enum is public should we also upstream the histogram definition (especially if we mention it in the comment). If yes, this should be done in a separate CL. Can you create a bug to track this?
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020023002/20001
Message was sent while issue was closed.
Description was changed from ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. Downstream CL: https://chromereviews.googleplex.com/432527013/ BUG=608337 ========== to ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. Downstream CL: https://chromereviews.googleplex.com/432527013/ BUG=608337 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. Downstream CL: https://chromereviews.googleplex.com/432527013/ BUG=608337 ========== to ========== Deprecate sign-in from share. In iOS7 and before, sharing could trigger the sign-in flow. This is not possible anymore in iOS 9. Downstream CL: https://chromereviews.googleplex.com/432527013/ BUG=608337 Committed: https://crrev.com/0c96540b3310595f91818ad186c0c017996dd314 Cr-Commit-Position: refs/heads/master@{#397475} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0c96540b3310595f91818ad186c0c017996dd314 Cr-Commit-Position: refs/heads/master@{#397475}
Message was sent while issue was closed.
On 2016/06/02 18:26:22, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/0c96540b3310595f91818ad186c0c017996dd314 > Cr-Commit-Position: refs/heads/master@{#397475} bug filed: https://bugs.chromium.org/p/chromium/issues/detail?id=617638 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
