Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/signin/constants.h

Issue 2020023002: Deprecate sign-in from share. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/commands/ios_command_ids.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/signin/constants.h
diff --git a/ios/chrome/browser/signin/constants.h b/ios/chrome/browser/signin/constants.h
index f0871cd5b59e090232d9bab71bfd74c4eb0aec9b..2ff5f98785cb4d450f8e7f22394a420cea28e117 100644
--- a/ios/chrome/browser/signin/constants.h
+++ b/ios/chrome/browser/signin/constants.h
@@ -38,7 +38,8 @@ typedef enum {
// Sign in operation was started from settings.
SIGN_IN_SOURCE_SETTINGS,
// Sign in operation was started from as a pre-requisite of share operation.
- SIGN_IN_SOURCE_SHARE,
+ // Deprecated since M53.
+ SIGN_IN_SOURCE_SHARE_DEPRECATED,
sdefresne 2016/05/30 14:16:29 We probably need to update Signin.IOSSignInSource
jif-google 2016/05/30 14:29:26 https://critique.corp.google.com/#review/123579885
sdefresne 2016/06/02 17:16:24 As the enum is public should we also upstream the
// Sign in operation was started from as a pre-requisite of a print operation.
SIGN_IN_SOURCE_PRINT,
// Sign in operation was started from the re-sign in infobar.
« no previous file with comments | « no previous file | ios/chrome/browser/ui/commands/ios_command_ids.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698