third_party/WebKit/Source/platform/heap/HeapTest.cpp - Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h ('K') | « third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp ('k') | third_party/WebKit/Source/platform/heap/Persistent.h » ('j') | third_party/WebKit/Source/platform/heap/Persistent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

index 7738623afd7e153052fc57af8f7d5803bc53044a..b803b70edf34496862ea7a12356a1b591c640194 100644

--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

@@ -521,7 +521,7 @@ public:

// terminating, preventing access to a finalized heap.

for (auto& globalIntWrapper : m_crossPersistents) {

ASSERT(globalIntWrapper.get());

- EXPECT_FALSE(globalIntWrapper.get()->get());

+ EXPECT_FALSE(static_cast<bool>(*globalIntWrapper.get()));

}