third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h - Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/Database.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp » ('j') | third_party/WebKit/Source/platform/heap/Persistent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h b/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

index 84deeb1a37e096f74da7b417f35f319e91b66420..8bb74f4b6bfb5ee9519831f8540ea6915600b277 100644

--- a/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

+++ b/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

@@ -50,7 +50,7 @@ public:

void run();

- Database* database() const { return m_database.get(); }

+ const CrossThreadPersistent<Database>& database() const { return m_database; }

#if ENABLE(ASSERT)

bool hasSynchronizer() const { return m_synchronizer; }

#endif

@@ -118,7 +118,7 @@ public:

return adoptPtr(new DatabaseTransactionTask(transaction));

}

- SQLTransactionBackend* transaction() const { return m_transaction.get(); }

+ CrossThreadPersistent<SQLTransactionBackend> transaction() const { return m_transaction; }

sof 2016/06/02 07:00:11 You're creating a CrossThreadPersistent<> here, is

private:

explicit DatabaseTransactionTask(SQLTransactionBackend*);