third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp - Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h » ('j') | third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

index 01136649524082b8b79b83dda662a2a4852c957e..b21f050a210afd3975936c1e6c51cdf94dabc915 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

@@ -278,7 +278,7 @@ void CanvasAsyncBlobCreator::encodeImageOnEncoderThread(double quality)

ASSERT(m_mimeType == MimeTypeWebp);

if (!ImageDataBuffer(m_size, m_data->data()).encodeImage("image/webp", quality, m_encodedImage.get())) {

- Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&BlobCallback::handleEvent, wrapCrossThreadPersistent(m_callback.get()), nullptr));

+ Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&BlobCallback::handleEvent, wrapCrossThreadPersistent(m_callback), nullptr));

return;

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h » ('j') | third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h » ('J')