Fix pylint unused-* warnings in webkitpy/tool.

Fix pylint unused-* warnings in webkitpy/tool.

This includes:
  unused-variable
  unused-argument
  unused-import

In some cases, unused arguments are there for method because the argument is required by the superclass or may be used in subclasses; in these cases I added a pylint disable pragma comment.

BUG=598897
Committed: https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5
Cr-Commit-Position: refs/heads/master@{#397636}

[qyearsley, 2016-05-29 21:07:50]

Description was changed from

==========
Fix pylint unused-* warnings in webkitpy/tool.

BUG=
==========

to

==========
Fix pylint unused-* warnings in webkitpy/tool.

BUG=598897
==========

[qyearsley, 2016-05-29 21:07:53]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-29 21:08:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019923002/1

[qyearsley, 2016-05-29 21:11:18]

Description was changed from

==========
Fix pylint unused-* warnings in webkitpy/tool.

BUG=598897
==========

to

==========
Fix pylint unused-* warnings in webkitpy/tool.

This includes:
  unused-variable
  unused-argument
  unused-import

In some cases, unused arguments are there for method because the argument is
required by the superclass or may be used in subclasses; in these cases I added
a pylint disable pragma comment.

BUG=598897
==========

[commit-bot: I haz the power, 2016-05-30 00:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 00:03:03]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-06-02 16:41:31]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, tansell@chromium.org

[qyearsley, 2016-06-02 16:41:32]

https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py
(right):

https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:44:
raise NotImplementedError('Subclasses should implement this method.')
Currently, all subclasses implement this, so the behavior will be the same.

https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py (right):

https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py:118: return
True
This is a case where there's only one subclass (WebkitPatch) and it implements
this function, so it may be conceivable to replace this with `raise
NotImplementedError`.

[Dirk Pranke, 2016-06-02 17:52:03]

lgtm

https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py (right):

https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py:118: return
True
On 2016/06/02 16:41:32, qyearsley wrote:
> This is a case where there's only one subclass (WebkitPatch) and it implements
> this function, so it may be conceivable to replace this with `raise
> NotImplementedError`.

If there's only one subclass we should just merge the two classes. I think it's
unlikely we'll add another multi-command script using this framework any time
soon.

[qyearsley, 2016-06-02 18:06:23]

On 2016/06/02 at 17:52:03, dpranke wrote:
> lgtm
> 
>
https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py
(right):
> 
>
https://codereview.chromium.org/2019923002/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py:118: return
True
> On 2016/06/02 16:41:32, qyearsley wrote:
> > This is a case where there's only one subclass (WebkitPatch) and it
implements
> > this function, so it may be conceivable to replace this with `raise
> > NotImplementedError`.
> 
> If there's only one subclass we should just merge the two classes. I think
it's unlikely we'll add another multi-command script using this framework any
time soon.

Makes sense -- made a note of this and will hopefully merge them in a future
change.

[qyearsley, 2016-06-02 18:06:25]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-02 18:06:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019923002/1

[commit-bot: I haz the power, 2016-06-02 18:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 18:12:01]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[qyearsley, 2016-06-02 22:14:05]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-02 22:14:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2019923002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-02 22:15:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019923002/20001

[commit-bot: I haz the power, 2016-06-03 03:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 03:58:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mithro, 2016-06-03 04:06:52]

LGTM too.

[mithro, 2016-06-03 04:06:58]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2016-06-03 04:07:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019923002/20001

[commit-bot: I haz the power, 2016-06-03 04:52:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 04:54:11]

Description was changed from

==========
Fix pylint unused-* warnings in webkitpy/tool.

This includes:
  unused-variable
  unused-argument
  unused-import

In some cases, unused arguments are there for method because the argument is
required by the superclass or may be used in subclasses; in these cases I added
a pylint disable pragma comment.

BUG=598897
==========

to

==========
Fix pylint unused-* warnings in webkitpy/tool.

This includes:
  unused-variable
  unused-argument
  unused-import

In some cases, unused arguments are there for method because the argument is
required by the superclass or may be used in subclasses; in these cases I added
a pylint disable pragma comment.

BUG=598897

Committed: https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5
Cr-Commit-Position: refs/heads/master@{#397636}
==========

[commit-bot: I haz the power, 2016-06-03 04:54:13]

Patchset 2 (id:??) landed as
https://crrev.com/3621e6f24d746662472d3e14db605d4dbb66e7c5
Cr-Commit-Position: refs/heads/master@{#397636}