Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer.py

Issue 2019923002: Fix pylint unused-* warnings in webkitpy/tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 def help(self): 82 def help(self):
83 self._post('Commands available: %s' % ' '.join(self.commands.keys())) 83 self._post('Commands available: %s' % ' '.join(self.commands.keys()))
84 84
85 def ping(self): 85 def ping(self):
86 self._post('Pong.') 86 self._post('Pong.')
87 87
88 def stop(self, message=""): 88 def stop(self, message=""):
89 self.connection.execute_delayed(0, lambda: self.die(message)) 89 self.connection.execute_delayed(0, lambda: self.die(message))
90 90
91 # IRC event handlers. 91 # IRC event handlers. Methods' arguments are determined by superclass
92 # and some arguments maybe unused - pylint: disable=unused-argument
92 93
93 def on_nicknameinuse(self, connection, event): 94 def on_nicknameinuse(self, connection, event):
94 connection.nick('%s_' % connection.get_nickname()) 95 connection.nick('%s_' % connection.get_nickname())
95 96
96 def on_welcome(self, connection, event): 97 def on_welcome(self, connection, event):
97 connection.join(channel) 98 connection.join(channel)
98 99
99 def on_pubmsg(self, connection, event): 100 def on_pubmsg(self, connection, event):
100 message = event.arguments()[0] 101 message = event.arguments()[0]
101 command = self._message_command(message) 102 command = self._message_command(message)
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 def __init__(self, tool, announce_path, irc_password): 192 def __init__(self, tool, announce_path, irc_password):
192 threading.Thread.__init__(self) 193 threading.Thread.__init__(self)
193 self.bot = CommitAnnouncer(tool, announce_path, irc_password) 194 self.bot = CommitAnnouncer(tool, announce_path, irc_password)
194 195
195 def run(self): 196 def run(self):
196 self.bot.start() 197 self.bot.start()
197 198
198 def stop(self): 199 def stop(self):
199 self.bot.stop() 200 self.bot.stop()
200 self.join() 201 self.join()
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698