tools/metrics/histograms/histograms.xml - Issue 2019783002: Add histograms for requests that were fetched successfully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2019783002: Add histograms for requests that were fetched successfully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed sclittle comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 004fd042fcfbb3f75d6027415828e52e465a012a..962fcd8a0232bfd00c7cd8ac7c72cf504d3f056f 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -7626,6 +7626,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="DataReductionProxy.SuccessfulRequestCompletionCounts">

Alexei Svitkine (slow) 2016/05/27 21:16:37 Nit: add units= Same below.

tbansal1 2016/05/27 22:35:11 Done.

+ <owner>tbansal@chromium.org</owner>

+ <owner>bengr@chromium.org</owner>

+ <summary>

+ Count of the number of requests that were successfully fetched via data

+ reduction proxy. The bucket represents the index of the data reduction proxy

+ in the data reduction proxy list.

+ </summary>

+</histogram>

+<histogram

+ name="DataReductionProxy.SuccessfulRequestCompletionCounts.MainFrame">

+ <owner>tbansal@chromium.org</owner>

+ <owner>bengr@chromium.org</owner>

+ <summary>

+ Count of the number of main frame requests that were successfully fetched

+ via data reduction proxy. The bucket represents the index of the data

+ reduction proxy in the data reduction proxy list.

+ </summary>

+</histogram>

<owner>bengr@chromium.org</owner>

<owner>megjablon@chromium.org</owner>