components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc - Issue 2019783002: Add histograms for requests that were fetched successfully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

Issue 2019783002: Add histograms for requests that were fetched successfully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed sclittle comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_params.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

index 2ea4b94a5d8ed5ba94468e617ed973059acb24c4..b5f0a5f12bb145064b9acbadc764d8a07435ef54 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

@@ -287,7 +287,7 @@ const char* GetServerExperimentsFieldTrialName() {

} // namespace params

-DataReductionProxyTypeInfo::DataReductionProxyTypeInfo() : is_fallback(false) {}

+DataReductionProxyTypeInfo::DataReductionProxyTypeInfo() : proxy_index(0) {}

DataReductionProxyTypeInfo::DataReductionProxyTypeInfo(

const DataReductionProxyTypeInfo& other) = default;