third_party/WebKit/LayoutTests/media/before-load-member-access.html - Issue 2019643002: Convert before-*, broken-* and constructors.html tests to testharness.js

Unified Diff: third_party/WebKit/LayoutTests/media/before-load-member-access.html

Issue 2019643002: Convert before-*, broken-* and constructors.html tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/before-load-member-access-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/broken-video.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/before-load-member-access.html

diff --git a/third_party/WebKit/LayoutTests/media/before-load-member-access.html b/third_party/WebKit/LayoutTests/media/before-load-member-access.html

index cbb3b0835304251ea9838c4507136a0bc85a06e6..a3222c0b7a64b9489908551b2299b0c657ca3420 100644

--- a/third_party/WebKit/LayoutTests/media/before-load-member-access.html

+++ b/third_party/WebKit/LayoutTests/media/before-load-member-access.html

@@ -1,28 +1,14 @@

-<html>

- <head>

- <title>Test that accessing member of a non loaded video works.</title>

- <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

- <script src=video-test.js></script>

- <script>

- function test()

- {

- findMediaElement();

- run("video.played");

- run("video.buffered");

- run("video.seekable");

- run("video.volume");

- consoleWrite("SUCCESS");

- endTest();

- }

- </script>

- </head>

-<body onload="test()">

- <video controls></video>

- <p>Test that accessing member of a non loaded video works.</p>

-</body>

-</html>

+<!DOCTYPE HTML>

+<title>Test that accessing member of a non loaded video works.</title>

foolip 2016/05/27 08:22:15 This test is a bit silly I think, it's a stretch t

fs 2016/05/27 08:31:13 Well, the new test is at least "pretty silly" (or

Srirama 2016/05/27 10:57:48 Except volume, others are TimeRange objects, so i

foolip 2016/05/27 11:29:25 Sounds good!

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<video></video>

+<script>

+test(function() {

+ var video = document.querySelector("video");

+ video.played;

+ video.buffered;

+ video.seekable;

+ video.volume;

+});

+</script>