third_party/WebKit/LayoutTests/media/before-load-member-access.html - Issue 2019643002: Convert before-*, broken-* and constructors.html tests to testharness.js

Side by Side Diff: third_party/WebKit/LayoutTests/media/before-load-member-access.html

Issue 2019643002: Convert before-*, broken-* and constructors.html tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/before-load-member-access-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/broken-video.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <!DOCTYPE HTML>

2 <head>	2 <title>Test that accessing member of a non loaded video works.</title>
	foolip 2016/05/27 08:22:15 This test is a bit silly I think, it's a stretch t This test is a bit silly I think, it's a stretch to think that merely accessing a member would throw an exception and fail this test. I mean there are such attributes, but it's a strange thing to test in general. Can you assert what the actual initial values are instead, so that it will be obvious later that this can be folded into other tests for the respective attributes? fs 2016/05/27 08:31:13 Well, the new test is at least "pretty silly" (or Show quoted text On 2016/05/27 at 08:22:15, Philip Jägenstedt wrote: > This test is a bit silly I think, it's a stretch to think that merely accessing a member would throw an exception and fail this test. I mean there are such attributes, but it's a strange thing to test in general. Well, the new test is at least "pretty silly" (or should that be "silly (but) pretty") while the old one was just "silly" =P Srirama 2016/05/27 10:57:48 Except volume, others are TimeRange objects, so i Show quoted text On 2016/05/27 08:22:15, Philip Jägenstedt wrote: > This test is a bit silly I think, it's a stretch to think that merely accessing > a member would throw an exception and fail this test. I mean there are such > attributes, but it's a strange thing to test in general. > > Can you assert what the actual initial values are instead, so that it will be > obvious later that this can be folded into other tests for the respective > attributes? Except volume, others are TimeRange objects, so i just asserted the length. foolip 2016/05/27 11:29:25 Sounds good! Show quoted text On 2016/05/27 10:57:48, Srirama wrote: > On 2016/05/27 08:22:15, Philip Jägenstedt wrote: > > This test is a bit silly I think, it's a stretch to think that merely > accessing > > a member would throw an exception and fail this test. I mean there are such > > attributes, but it's a strange thing to test in general. > > > > Can you assert what the actual initial values are instead, so that it will be > > obvious later that this can be folded into other tests for the respective > > attributes? > > Except volume, others are TimeRange objects, so i just asserted the length. Sounds good!
3 <title>Test that accessing member of a non loaded video works.</title>	3 <script src="../resources/testharness.js"></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	4 <script src="../resources/testharnessreport.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	5 <video></video>

6 <script src=video-test.js></script>	6 <script>

7 <script>	7 test(function() {

8 function test()	8 var video = document.querySelector("video");

9 {	9 video.played;

10 findMediaElement();	10 video.buffered;

11	11 video.seekable;

12 run("video.played");	12 video.volume;

13 run("video.buffered");	13 });

14 run("video.seekable");	14 </script>

15 run("video.volume");

16 consoleWrite("SUCCESS");

17 endTest();

18 }

19 </script>

20 </head>

21

22 <body onload="test()">

23

24 <video controls></video>

25 <p>Test that accessing member of a non loaded video works.</p>

26

27 </body>

28 </html>

OLD	NEW