third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 2019583002: Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2019583002: Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/invalidation-on-foreground-graphics-layer-expected.txt ('K') | « third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-content-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

index cffef09efb130e30eaa221b0988326dc2f01cafb..813deb311a500b9ad4c8d7e6eb1fb062131c5bac 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

@@ -292,7 +292,9 @@ public:

// The rect is in the physical coordinate space of this layout object.

void setBackingNeedsPaintInvalidationInRect(const LayoutRect&, PaintInvalidationReason, const LayoutObject&) const;

- void invalidateDisplayItemClientOnBacking(const DisplayItemClient&, PaintInvalidationReason) const;

+ // The third parameter should be equal to the DisplayItemClient if it happens to be a LayoutObjert subclass. It is only used

wkorman 2016/05/31 18:34:15 LayoutObjert -> LayoutObject

chrishtr 2016/05/31 18:51:54 Done.

+ // for debugging.

+ void invalidateDisplayItemClientOnBacking(const DisplayItemClient&, PaintInvalidationReason, const LayoutObject* = nullptr) const;

// http://www.w3.org/TR/css3-background/#body-background

// <html> root element with no background steals background from its first <body> child.